Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0051598
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Coremajorhave not tried2023-02-14 15:532023-05-03 13:28
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version23Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression levelPackaging and release
Regression date2022-11-08
Regression introduced in releasemain
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/6d5485e031a5f1b887abb62d565bd98eeb5a5b54 [^]
Triggers an Emergency PackNo
Summary

0051598: Some terminal log messages are lost when logging out

DescriptionIn this commit [1] we made a change to move terminal log messages from memory to IndexedDB. The problem is that some properties that are usually added to the payload when the terminalLogGenerateMessage state action is executed, but that are not being passed when invoking directly the utility action.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/6d5485e031a5f1b887abb62d565bd98eeb5a5b54 [^]
Steps To ReproduceCan be reproduced in livebuilds:
- Open POS2:
https://livebuilds.openbravo.com/retail_pos2_pgsql/web/pos/?terminal=VBS-2 [^]
- Log in, create a ticket, and do a cashup. This will generate terminal log messages
- Log in to ensure all messages are sent to the backend
- Check in the log that some errors have been logged in the console and as a result some messages are not saved in the terminal log table: https://livebuilds.openbravo.com/logs/retail_pos2_pgsql_openbravo.log [^]

2023-02-14 08:54:10,592 [Import Entry - 2] ERROR org.openbravo.mobile.core.terminallog.StoreTerminalLogEventInDatabase - Could not save UserEvent log with info: {"events":"[{\"d\":1676364824165,\"o\":false,\"n\":\"OBC2_Logout\",\"e\":\"action\",\"c\":\"79C6A4513DBF8E2AE20633A77A614DC4\",\"i\":\"skipConfirmation:true - userActionsInProgress: []\",\"t\":\"as\"},{\"d\":1676364824180,\"o\":false,\"n\":\"OBPOS2_ResetProductSearch\",\"e\":\"action\",\"c\":\"79C6A4513DBF8E2AE20633A77A614DC4\",\"i\":\"userActionsInProgress: [\\\"OBC2_Logout\\\"]\",\"t\":\"as\"},{\"d\":1676364824189,\"o\":false,\"n\":\"OBPOS2_ResetProductSearch\",\"e\":\"action\",\"c\":\"79C6A4513DBF8E2AE20633A77A614DC4\",\"i\":\"userActionsInProgress: [\\\"OBC2_Logout\\\",\\\"OBPOS2_ResetProductSearch\\\"]\",\"t\":\"afs\"}]","extraProperties":{"ignoreForSessionTimeout":true}}
org.codehaus.jettison.json.JSONException: JSONObject["terminal"] not found.
    at org.codehaus.jettison.json.JSONObject.get(JSONObject.java:360) ~[jettison-1.3-patched.jar:?]
    at org.codehaus.jettison.json.JSONObject.getString(JSONObject.java:487) ~[jettison-1.3-patched.jar:?]
...
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 005159923Q1.2 closedAugustoMauch Some terminal log messages are lost when logging out 
depends on backport 005232423Q2.1 closedAugustoMauch Some terminal log messages are lost when logging out 

-  Notes
(0149151)
hgbot (developer)
2023-05-02 16:41

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1071 [^]
(0149201)
hgbot (developer)
2023-05-03 13:28

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 3c99d61758f0f1a8f3636419b7ef6beda0350a18
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 03-05-2023 11:28:08
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/3c99d61758f0f1a8f3636419b7ef6beda0350a18 [^]

Fixes ISSUE-51598: Adds missing properties to terminal log messages

Some mandatory terminal log properties were not being included in the call to terminalLogGenerateMessage. Those
properties are usually included in an actionPreparation of TerminalLog. But as the utility function is directly invoked those
properties must be entered manually, so a new actionPreparation has been
added for clearSession state action to include the missing properties.

---
M web-jspack/org.openbravo.core2/src/model/session/Session.js
M web-jspack/org.openbravo.core2/src/model/session/__test__/ClearSession-actionPreparation.test.js
M web-jspack/org.openbravo.core2/src/model/session/actions/ClearSessionActionPreparation.js
---
(0149202)
hgbot (developer)
2023-05-03 13:28

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1071 [^]

- Issue History
Date Modified Username Field Change
2023-02-14 15:53 AugustoMauch New Issue
2023-02-14 15:53 AugustoMauch Assigned To => AugustoMauch
2023-02-14 15:53 AugustoMauch Regression level => Packaging and release
2023-02-14 15:53 AugustoMauch Regression date => 2022-11-08
2023-02-14 15:53 AugustoMauch Regression introduced in release => main
2023-02-14 15:53 AugustoMauch Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/6d5485e031a5f1b887abb62d565bd98eeb5a5b54 [^]
2023-02-14 15:53 AugustoMauch Triggers an Emergency Pack => No
2023-02-14 15:53 AugustoMauch Status new => scheduled
2023-05-02 16:41 hgbot Note Added: 0149151
2023-05-03 12:03 cberner Status scheduled => acknowledged
2023-05-03 12:03 cberner Status acknowledged => scheduled
2023-05-03 13:28 hgbot Resolution open => fixed
2023-05-03 13:28 hgbot Status scheduled => closed
2023-05-03 13:28 hgbot Fixed in Version => 23Q3
2023-05-03 13:28 hgbot Note Added: 0149201
2023-05-03 13:28 hgbot Note Added: 0149202

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker