0051599: Some terminal log messages are lost when logging out

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0051599

POS2

Core

public

2023-02-14 15:53

2023-05-03 13:28

Reporter

AugustoMauch

Assigned To

AugustoMauch

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

23Q1.2

Fixed in Version

23Q1.2

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Packaging and release

Regression date

2022-11-08

Regression introduced in release

main

Regression introduced by commit

https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/6d5485e031a5f1b887abb62d565bd98eeb5a5b54 [^]

Triggers an Emergency Pack

Summary

0051599: Some terminal log messages are lost when logging out

Description

In this commit [1] we made a change to move terminal log messages from memory to IndexedDB. The problem is that some properties that are usually added to the payload when the terminalLogGenerateMessage state action is executed, but that are not being passed when invoking directly the utility action.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/6d5485e031a5f1b887abb62d565bd98eeb5a5b54 [^]

Steps To Reproduce

Can be reproduced in livebuilds:
- Open POS2:
https://livebuilds.openbravo.com/retail_pos2_pgsql/web/pos/?terminal=VBS-2 [^]
- Log in, create a ticket, and do a cashup. This will generate terminal log messages
- Log in to ensure all messages are sent to the backend
- Check in the log that some errors have been logged in the console and as a result some messages are not saved in the terminal log table: https://livebuilds.openbravo.com/logs/retail_pos2_pgsql_openbravo.log [^]

2023-02-14 08:54:10,592 [Import Entry - 2] ERROR org.openbravo.mobile.core.terminallog.StoreTerminalLogEventInDatabase - Could not save UserEvent log with info: {"events":"[{\"d\":1676364824165,\"o\":false,\"n\":\"OBC2_Logout\",\"e\":\"action\",\"c\":\"79C6A4513DBF8E2AE20633A77A614DC4\",\"i\":\"skipConfirmation:true - userActionsInProgress: []\",\"t\":\"as\"},{\"d\":1676364824180,\"o\":false,\"n\":\"OBPOS2_ResetProductSearch\",\"e\":\"action\",\"c\":\"79C6A4513DBF8E2AE20633A77A614DC4\",\"i\":\"userActionsInProgress: [\\\"OBC2_Logout\\\"]\",\"t\":\"as\"},{\"d\":1676364824189,\"o\":false,\"n\":\"OBPOS2_ResetProductSearch\",\"e\":\"action\",\"c\":\"79C6A4513DBF8E2AE20633A77A614DC4\",\"i\":\"userActionsInProgress: [\\\"OBC2_Logout\\\",\\\"OBPOS2_ResetProductSearch\\\"]\",\"t\":\"afs\"}]","extraProperties":{"ignoreForSessionTimeout":true}}
org.codehaus.jettison.json.JSONException: JSONObject["terminal"] not found.
at org.codehaus.jettison.json.JSONObject.get(JSONObject.java:360) ~[jettison-1.3-patched.jar:?]
at org.codehaus.jettison.json.JSONObject.getString(JSONObject.java:487) ~[jettison-1.3-patched.jar:?]
...

Proposed Solution

Additional Information