Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050650 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | have not tried | 2022-10-27 01:38 | 2023-01-16 11:42 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 23Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050650: Keymap editor should not load product images when creating the keymap configuration | |||||||
| Description | The product images are not displayed in window that allows to edit the keymap layout. But we have noticed that currently when creating the keymap configuration and storing the info about the products in the assortment, the images are being loaded and they taking a lot of space in memory. This problem of wasting space with products images is made bigger by a memory leak that will be fixed on a separate issue: each time the resolution of the keymap to be edited is changed, a new configuration is built but the previous one remains in memory. | |||||||
| Steps To Reproduce | - Use a big keymap that contains product images. - Open the keymap editor, select a keymap with many images, go to the edit layout step. - Take a memory heap - Change the resolution of the keymap being edited several times - Take another memory heap. Notice that the size of the heap has increased a lot | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||||||||||||||||
|
||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0142628) hgbot (developer) 2022-10-27 01:43 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1318 [^] |
|
(0142667) hgbot (developer) 2022-10-27 14:05 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1318 [^] |
|
(0142670) hgbot (developer) 2022-10-27 14:05 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 8240ae40495ee5cf44f99914571a0fdc89e7184e Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 27-10-2022 12:03:58 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8240ae40495ee5cf44f99914571a0fdc89e7184e [^] Fixes ISSUE-50650: Do not store product img info in keymap editor context The keymap editor does not make use of the product images, but product images were being saved in several properties of the context (keymapProduct array, product assortment array). We can save a lot of memory just by removing the product images before storing the information in the context of the component --- M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeyMapEditorLayout.jsx --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-10-27 01:38 | AugustoMauch | New Issue | |
| 2022-10-27 01:38 | AugustoMauch | Assigned To | => AugustoMauch |
| 2022-10-27 01:38 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2022-10-27 01:38 | AugustoMauch | Status | new => scheduled |
| 2022-10-27 01:43 | hgbot | Note Added: 0142628 | |
| 2022-10-27 14:05 | hgbot | Note Added: 0142667 | |
| 2022-10-27 14:05 | hgbot | Resolution | open => fixed |
| 2022-10-27 14:05 | hgbot | Status | scheduled => closed |
| 2022-10-27 14:05 | hgbot | Fixed in Version | => 23Q1 |
| 2022-10-27 14:05 | hgbot | Note Added: 0142670 | |
| 2022-11-09 09:08 | jarmendariz | Relationship added | related to 0050792 |
| 2023-01-16 11:42 | lorenzofidalgo | Steps to Reproduce Updated | View Revisions |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |