Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050651
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] POSmajorhave not tried2022-10-27 01:382022-10-27 14:05
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version22Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version22Q4.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050651: Keymap editor should not load product images when creating the keymap configuration

DescriptionThe product images are not displayed in window that allows to edit the keymap layout. But we have noticed that currently when creating the keymap configuration and storing the info about the products in the assortment, the images are being loaded and they taking a lot of space in memory.

This problem of wasting space with products images is made bigger by a memory leak that will be fixed on a separate issue: each time the resolution of the keymap to be edited is changed, a new configuration is built but the previous one remains in memory.
Steps To Reproduce- Use a big keymap that contains product images (i.e. restaurant keymap in agapes-fs-u18-test.cloud.openbravo.com)
- Open the keymap editor, select a keymap with many images, go to the edit layout step.
- Take a memory heap
- Change the resolution of the keymap being edited several times
- Take another memory heap. Notice that the size of the heap has increased a lot
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0050650 closedAugustoMauch Keymap editor should not load product images when creating the keymap configuration 

-  Notes
(0142643)
hgbot (developer)
2022-10-27 12:58

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1320 [^]
(0142668)
hgbot (developer)
2022-10-27 14:05

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1320 [^]
(0142669)
hgbot (developer)
2022-10-27 14:05

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 22279646d99855ec258b4d0205ed0424e2269749
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 27-10-2022 12:04:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/22279646d99855ec258b4d0205ed0424e2269749 [^]

Fixes ISSUE-50651: Do not store product img info in keymap editor context

The keymap editor does not make use of the product images, but product images were being saved in several properties of the
context (keymapProduct array, product assortment array). We can save a lot of memory just by removing the product images before
storing the information in the context of the component

---
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeyMapEditorLayout.jsx
---

- Issue History
Date Modified Username Field Change
2022-10-27 01:38 AugustoMauch Type defect => backport
2022-10-27 01:38 AugustoMauch Target Version => 22Q4.1
2022-10-27 12:58 hgbot Note Added: 0142643
2022-10-27 14:05 hgbot Resolution open => fixed
2022-10-27 14:05 hgbot Status scheduled => closed
2022-10-27 14:05 hgbot Note Added: 0142668
2022-10-27 14:05 hgbot Fixed in Version => 22Q4
2022-10-27 14:05 hgbot Note Added: 0142669

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker