Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050650POS2POSpublic2022-10-27 01:382023-01-16 11:42
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050650: Keymap editor should not load product images when creating the keymap configuration
DescriptionThe product images are not displayed in window that allows to edit the keymap layout. But we have noticed that currently when creating the keymap configuration and storing the info about the products in the assortment, the images are being loaded and they taking a lot of space in memory.

This problem of wasting space with products images is made bigger by a memory leak that will be fixed on a separate issue: each time the resolution of the keymap to be edited is changed, a new configuration is built but the previous one remains in memory.
Steps To Reproduce- Use a big keymap that contains product images.
- Open the keymap editor, select a keymap with many images, go to the edit layout step.
- Take a memory heap
- Change the resolution of the keymap being edited several times
- Take another memory heap. Notice that the size of the heap has increased a lot
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005065122Q4.1 closed AugustoMauch Keymap editor should not load product images when creating the keymap configuration 
depends on backport 005065222Q3.2 closed AugustoMauch Keymap editor should not load product images when creating the keymap configuration 
related to defect 0050792 closed Triage Platform Base Memory Leak on KeymapEditorResolutionSelector 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-10-27 01:38AugustoMauchNew Issue
2022-10-27 01:38AugustoMauchAssigned To => AugustoMauch
2022-10-27 01:38AugustoMauchTriggers an Emergency Pack => No
2022-10-27 01:38AugustoMauchStatusnew => scheduled
2022-10-27 01:43hgbotNote Added: 0142628
2022-10-27 14:05hgbotNote Added: 0142667
2022-10-27 14:05hgbotResolutionopen => fixed
2022-10-27 14:05hgbotStatusscheduled => closed
2022-10-27 14:05hgbotFixed in Version => 23Q1
2022-10-27 14:05hgbotNote Added: 0142670
2022-11-09 09:08jarmendarizRelationship addedrelated to 0050792
2023-01-16 11:42lorenzofidalgoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25394#r25394

Notes
(0142628)
hgbot   
2022-10-27 01:43   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1318 [^]
(0142667)
hgbot   
2022-10-27 14:05   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1318 [^]
(0142670)
hgbot   
2022-10-27 14:05   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8240ae40495ee5cf44f99914571a0fdc89e7184e
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 27-10-2022 12:03:58
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8240ae40495ee5cf44f99914571a0fdc89e7184e [^]

Fixes ISSUE-50650: Do not store product img info in keymap editor context

The keymap editor does not make use of the product images, but product images were being saved in several properties of the
context (keymapProduct array, product assortment array). We can save a lot of memory just by removing the product images before
storing the information in the context of the component

---
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeyMapEditorLayout.jsx
---