Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0050458
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[POS2] Coreminorhave not tried2022-10-10 08:372023-03-28 08:33
ReporterjonaeView Statuspublic 
Assigned Tojonae 
PrioritynormalResolutionfixedFixed in Version23Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050458: askConfirmation API should have a configuration to avoid dismissing the dialog

DescriptionSome functionalities needs to remove the X icon from the top right in order to maintain the window open till the user makes an action on the buttons. To do that a new parameter needs to be added to BaseDialog to remove that icon depending on it. By default would be false, so the icon will be shown.

Note that the X icon and the ability of closing the popup when clicking outside are two ways of doing the same: dismissing the dialog. So, when the X is not displayed, clicking outside should not close the dialog also.
Steps To ReproduceSome functionalities needs to remove the X icon from the top right in order to maintain the window open till the user makes an action on the buttons. To do that a new parameter needs to be added to BaseDialog to remove that icon depending on it. By default would be false, so the icon will be shown.
Proposed SolutionImplement this ability in askConfirmation, askMultiOptionDialog and inputData APIs
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 005099222Q4.1 closedjavierRodriguez POS2 askConfirmation API should have a configuration to avoid dismissing the dialog 
depends on backport 005099322Q3.3 closedjavierRodriguez POS2 askConfirmation API should have a configuration to avoid dismissing the dialog 
blocks feature request 0050230 closedaferraz Retail Modules Implement open/close store process in ReactPOS 

-  Notes
(0142063)
hgbot (developer)
2022-10-14 11:05

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/871 [^]
(0142379)
hgbot (developer)
2022-10-21 09:36

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 1ed5e7da9f8e866b1cf998ff7bc20385de41df0d
Author: Jon Alegría <jon.alegria@openbravo.com>
Date: 21-10-2022 07:36:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/1ed5e7da9f8e866b1cf998ff7bc20385de41df0d [^]

Fixes BUG-50458: Support avoid dismissing the dialog in askConfirmation and inputData APIs

---
M web-jspack/org.openbravo.core2/src/components/ConfirmationDialog/ConfirmationDialog.jsx
M web-jspack/org.openbravo.core2/src/components/ConfirmationDialog/__test__/ConfirmationDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/ConfirmationDialog/stories/ConfirmationDialog.stories.jsx
M web-jspack/org.openbravo.core2/src/components/InputDataDialog/InputDataDialog.jsx
M web-jspack/org.openbravo.core2/src/components/MultiButtonStandardDialog/MultiButtonStandardDialog.jsx
M web-jspack/org.openbravo.core2/src/components/MultiOptionDialog/MultiOptionDialog.jsx
M web-jspack/org.openbravo.core2/src/components/MultiOptionDialog/__test__/MultiOptionDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/MultiOptionDialog/stories/MultiOptionDialog.stories.jsx
M web-jspack/org.openbravo.core2/src/components/StandardDialog/StandardDialog.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/StandardInputDataDialog.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/__test__/StandardInputDataDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/stories/StandardInputDataDialog.stories.jsx
---
(0142380)
hgbot (developer)
2022-10-21 09:36

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/871 [^]

- Issue History
Date Modified Username Field Change
2022-10-10 08:37 jonae New Issue
2022-10-10 08:37 jonae Assigned To => jonae
2022-10-10 08:37 jonae Triggers an Emergency Pack => No
2022-10-10 12:17 jonae File Added: 50458.diff
2022-10-10 13:13 jonae Assigned To jonae => Triage Platform Base
2022-10-10 13:16 aferraz Category POS => Core
2022-10-10 13:20 aferraz Assigned To Triage Platform Base => jonae
2022-10-14 11:05 hgbot Note Added: 0142063
2022-10-14 11:16 jonae File Deleted: 50458.diff
2022-10-14 11:16 jonae Assigned To jonae => Triage Platform Base
2022-10-21 09:28 caristu Description Updated View Revisions
2022-10-21 09:28 caristu Assigned To Triage Platform Base => jonae
2022-10-21 09:30 caristu Summary BaseDialog component needs to implement the hide close functionality to remove the X icon from the top right when needed => BaseDialog component needs to implement the ability of avoid dismissing it
2022-10-21 09:32 caristu Summary BaseDialog component needs to implement the ability of avoid dismissing it => askConfirmation API should have a configuration to avoid dismissing the dialog
2022-10-21 09:36 hgbot Resolution open => fixed
2022-10-21 09:36 hgbot Status new => closed
2022-10-21 09:36 hgbot Fixed in Version => 23Q1
2022-10-21 09:36 hgbot Note Added: 0142379
2022-10-21 09:36 hgbot Note Added: 0142380
2022-10-21 09:37 caristu Proposed Solution updated
2022-10-21 12:55 aferraz Relationship added blocks 0050230
2022-11-24 11:02 javierRodriguez Status closed => new
2022-11-24 11:02 javierRodriguez Resolution fixed => open
2022-11-24 11:02 javierRodriguez Fixed in Version 23Q1 =>
2022-11-24 11:03 javierRodriguez Status new => scheduled
2023-03-28 08:32 caristu Status scheduled => resolved
2023-03-28 08:32 caristu Fixed in Version => 22Q4
2023-03-28 08:32 caristu Resolution open => fixed
2023-03-28 08:33 caristu Fixed in Version 22Q4 => 23Q1
2023-03-28 08:33 caristu Review Assigned To => caristu
2023-03-28 08:33 caristu Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker