Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050458POS2Corepublic2022-10-10 08:372023-03-28 08:33
Reporterjonae 
Assigned Tojonae 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050458: askConfirmation API should have a configuration to avoid dismissing the dialog
DescriptionSome functionalities needs to remove the X icon from the top right in order to maintain the window open till the user makes an action on the buttons. To do that a new parameter needs to be added to BaseDialog to remove that icon depending on it. By default would be false, so the icon will be shown.

Note that the X icon and the ability of closing the popup when clicking outside are two ways of doing the same: dismissing the dialog. So, when the X is not displayed, clicking outside should not close the dialog also.
Steps To ReproduceSome functionalities needs to remove the X icon from the top right in order to maintain the window open till the user makes an action on the buttons. To do that a new parameter needs to be added to BaseDialog to remove that icon depending on it. By default would be false, so the icon will be shown.
Proposed SolutionImplement this ability in askConfirmation, askMultiOptionDialog and inputData APIs
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005099222Q4.1 closed javierRodriguez POS2 askConfirmation API should have a configuration to avoid dismissing the dialog 
depends on backport 005099322Q3.3 closed javierRodriguez POS2 askConfirmation API should have a configuration to avoid dismissing the dialog 
blocks feature request 0050230 closed aferraz Retail Modules Implement open/close store process in ReactPOS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-10-10 08:37jonaeNew Issue
2022-10-10 08:37jonaeAssigned To => jonae
2022-10-10 08:37jonaeTriggers an Emergency Pack => No
2022-10-10 12:17jonaeFile Added: 50458.diff
2022-10-10 13:13jonaeAssigned Tojonae => Triage Platform Base
2022-10-10 13:16aferrazCategoryPOS => Core
2022-10-10 13:20aferrazAssigned ToTriage Platform Base => jonae
2022-10-14 11:05hgbotNote Added: 0142063
2022-10-14 11:16jonaeFile Deleted: 50458.diff
2022-10-14 11:16jonaeAssigned Tojonae => Triage Platform Base
2022-10-21 09:28caristuDescription Updatedbug_revision_view_page.php?rev_id=24949#r24949
2022-10-21 09:28caristuAssigned ToTriage Platform Base => jonae
2022-10-21 09:30caristuSummaryBaseDialog component needs to implement the hide close functionality to remove the X icon from the top right when needed => BaseDialog component needs to implement the ability of avoid dismissing it
2022-10-21 09:32caristuSummaryBaseDialog component needs to implement the ability of avoid dismissing it => askConfirmation API should have a configuration to avoid dismissing the dialog
2022-10-21 09:36hgbotResolutionopen => fixed
2022-10-21 09:36hgbotStatusnew => closed
2022-10-21 09:36hgbotFixed in Version => 23Q1
2022-10-21 09:36hgbotNote Added: 0142379
2022-10-21 09:36hgbotNote Added: 0142380
2022-10-21 09:37caristuProposed Solution updated
2022-10-21 12:55aferrazRelationship addedblocks 0050230
2022-11-24 11:02javierRodriguezStatusclosed => new
2022-11-24 11:02javierRodriguezResolutionfixed => open
2022-11-24 11:02javierRodriguezFixed in Version23Q1 =>
2022-11-24 11:03javierRodriguezStatusnew => scheduled
2023-03-28 08:32caristuStatusscheduled => resolved
2023-03-28 08:32caristuFixed in Version => 22Q4
2023-03-28 08:32caristuResolutionopen => fixed
2023-03-28 08:33caristuFixed in Version22Q4 => 23Q1
2023-03-28 08:33caristuReview Assigned To => caristu
2023-03-28 08:33caristuStatusresolved => closed

Notes
(0142063)
hgbot   
2022-10-14 11:05   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/871 [^]
(0142379)
hgbot   
2022-10-21 09:36   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 1ed5e7da9f8e866b1cf998ff7bc20385de41df0d
Author: Jon Alegría <jon.alegria@openbravo.com>
Date: 21-10-2022 07:36:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/1ed5e7da9f8e866b1cf998ff7bc20385de41df0d [^]

Fixes BUG-50458: Support avoid dismissing the dialog in askConfirmation and inputData APIs

---
M web-jspack/org.openbravo.core2/src/components/ConfirmationDialog/ConfirmationDialog.jsx
M web-jspack/org.openbravo.core2/src/components/ConfirmationDialog/__test__/ConfirmationDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/ConfirmationDialog/stories/ConfirmationDialog.stories.jsx
M web-jspack/org.openbravo.core2/src/components/InputDataDialog/InputDataDialog.jsx
M web-jspack/org.openbravo.core2/src/components/MultiButtonStandardDialog/MultiButtonStandardDialog.jsx
M web-jspack/org.openbravo.core2/src/components/MultiOptionDialog/MultiOptionDialog.jsx
M web-jspack/org.openbravo.core2/src/components/MultiOptionDialog/__test__/MultiOptionDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/MultiOptionDialog/stories/MultiOptionDialog.stories.jsx
M web-jspack/org.openbravo.core2/src/components/StandardDialog/StandardDialog.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/StandardInputDataDialog.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/__test__/StandardInputDataDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/stories/StandardInputDataDialog.stories.jsx
---
(0142380)
hgbot   
2022-10-21 09:36   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/871 [^]