Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0050993
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] Coreminorhave not tried2022-10-10 08:372022-11-24 16:17
ReporterjonaeView Statuspublic 
Assigned TojavierRodriguez 
PrioritynormalResolutionfixedFixed in Version22Q3.3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version22Q3.3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050993: askConfirmation API should have a configuration to avoid dismissing the dialog

DescriptionSome functionalities needs to remove the X icon from the top right in order to maintain the window open till the user makes an action on the buttons. To do that a new parameter needs to be added to BaseDialog to remove that icon depending on it. By default would be false, so the icon will be shown.

Note that the X icon and the ability of closing the popup when clicking outside are two ways of doing the same: dismissing the dialog. So, when the X is not displayed, clicking outside should not close the dialog also.
Steps To ReproduceSome functionalities needs to remove the X icon from the top right in order to maintain the window open till the user makes an action on the buttons. To do that a new parameter needs to be added to BaseDialog to remove that icon depending on it. By default would be false, so the icon will be shown.
Proposed SolutionImplement this ability in askConfirmation, askMultiOptionDialog and inputData APIs
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks feature request 0050458 closedjonae askConfirmation API should have a configuration to avoid dismissing the dialog 

-  Notes
(0144105)
hgbot (developer)
2022-11-24 12:36

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/927 [^]
(0144115)
hgbot (developer)
2022-11-24 16:17

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/927 [^]
(0144116)
hgbot (developer)
2022-11-24 16:17

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 1dc7d731a55ca3d8572186c9c14a62be2697211c
Author: Jon Alegría <jon.alegria@openbravo.com>
Date: 24-11-2022 16:05:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/1dc7d731a55ca3d8572186c9c14a62be2697211c [^]

Fixes BUG-50993: Support avoid dismissing the dialog in askConfirmation and inputData APIs

---
M web-jspack/org.openbravo.core2/src/components/ConfirmationDialog/__test__/ConfirmationDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/ConfirmationDialog/stories/ConfirmationDialog.stories.jsx
M web-jspack/org.openbravo.core2/src/components/InputDataDialog/InputDataDialog.jsx
M web-jspack/org.openbravo.core2/src/components/MultiButtonStandardDialog/MultiButtonStandardDialog.jsx
M web-jspack/org.openbravo.core2/src/components/MultiOptionDialog/MultiOptionDialog.jsx
M web-jspack/org.openbravo.core2/src/components/MultiOptionDialog/__test__/MultiOptionDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/MultiOptionDialog/stories/MultiOptionDialog.stories.jsx
M web-jspack/org.openbravo.core2/src/components/StandardDialog/StandardDialog.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/StandardInputDataDialog.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/__test__/StandardInputDataDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/stories/StandardInputDataDialog.stories.jsx
---

- Issue History
Date Modified Username Field Change
2022-11-24 11:03 javierRodriguez Type feature request => backport
2022-11-24 11:03 javierRodriguez Target Version => 22Q3.3
2022-11-24 11:04 javierRodriguez Assigned To jonae => javierRodriguez
2022-11-24 12:36 hgbot Note Added: 0144105
2022-11-24 16:17 hgbot Resolution open => fixed
2022-11-24 16:17 hgbot Status scheduled => closed
2022-11-24 16:17 hgbot Note Added: 0144115
2022-11-24 16:17 hgbot Fixed in Version => 22Q3.3
2022-11-24 16:17 hgbot Note Added: 0144116


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker