Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050357 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] Core | major | have not tried | 2022-09-27 18:08 | 2023-08-07 13:25 | |||
| Reporter | adrianromero | View Status | public | |||||
| Assigned To | meriem_azaf | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050357: OnLoginActions do not allow to display UI | |||||||
| Description | OnLoginActions are asynchronous and in cases like Fiscalization events and other events it is required to display UI dialogs. But this UI never appears and the cashier cannot interact with it because it is rendered but behind the loading panel | |||||||
| Steps To Reproduce | Register the following login action and verify the ask confirmation expression is reached but the console log expression is never reached and the application never ends the login action because there is a dialog behind the loading panel the cashier cannot interact with it. See the screenshots attached. import OB from 'org.openbravo.core2/src/core/OB'; import OnLoginActions from 'org.openbravo.core2/src/core/authentication/OnLoginActions'; import './assets/style/main.scss'; export async function register() { OnLoginActions.registerAction(OB.EVTFIS.fiscalizationLogin); OnLoginActions.registerAction(async () => { await OB.App.View.DialogUIHandler.askConfirmation({ title: 'Login dialog title', message: 'message', hideCancel: true }); console.log('End login action.'); }); } export async function init() { // Nothing } | |||||||
| Proposed Solution | The loading panel should not be in top of all the UI it should only replace the POS application. This way dialogs and modals can be rendered on top of the loading panel. Loading Screen component has a z-index of 2000 to be on top of all other material UI components according the change comment: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/ec4dd5ede9bbd089d3508bbd5c83a4f35c3222cf [^] This is OK fdr common components but not for modals, snackbars or tooltips See z-index for material UI components: https://mui.com/material-ui/customization/z-index/ [^] The proposal is to change the z-index to 1250 for the Loading Screen component to be on top of regular material ui components but not for modals, snackbars or tooltips. The proposed change fixes this issue: diff --git a/web-jspack/org.openbravo.core2/src/components/LoadingScreen/LoadingScreen.scss b/web-jspack/org.openbravo.core2/src/components/LoadingScreen/LoadingScreen.scss index c30838ef..6fe19787 100644 --- a/web-jspack/org.openbravo.core2/src/components/LoadingScreen/LoadingScreen.scss +++ b/web-jspack/org.openbravo.core2/src/components/LoadingScreen/LoadingScreen.scss @@ -14,7 +14,7 @@ .obc2LoadingScreen-container .obc2LoadingScreen { position: absolute; - z-index: 2000; /* This screen has to be above any other element */ + z-index: 1250; /* This screen has to be above any other element but not modals, with z-index: 1300 */ display: grid; align-items: center; justify-items: center; | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  loginlocked.png [^] (179,554 bytes) 2022-09-27 18:10
hiddingloading.png [^] (251,144 bytes) 2022-09-27 18:11
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||||||||||||||||
|
||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0141448) adrianromero (manager) 2022-09-28 16:08 |
Linked Jira ticket: https://openbravo.atlassian.net/browse/RM-3115 [^] |
|
(0149653) hgbot (developer) 2023-05-12 09:43 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1094 [^] |
|
(0149691) hgbot (developer) 2023-05-15 09:43 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1094 [^] |
|
(0153297) adrianromero (manager) 2023-08-07 13:24 |
https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1094 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-09-27 18:08 | adrianromero | New Issue | |
| 2022-09-27 18:08 | adrianromero | Assigned To | => Triage Platform Base |
| 2022-09-27 18:08 | adrianromero | Triggers an Emergency Pack | => No |
| 2022-09-27 18:10 | adrianromero | File Added: loginlocked.png | |
| 2022-09-27 18:11 | adrianromero | File Added: hiddingloading.png | |
| 2022-09-28 16:08 | adrianromero | Note Added: 0141448 | |
| 2023-02-28 11:08 | adrianromero | Proposed Solution updated | |
| 2023-02-28 11:19 | adrianromero | Proposed Solution updated | |
| 2023-05-11 17:36 | adrianromero | Relationship added | has duplicate 0052418 |
| 2023-05-12 09:20 | AugustoMauch | Assigned To | Triage Platform Base => meriem_azaf |
| 2023-05-12 09:43 | hgbot | Note Added: 0149653 | |
| 2023-05-12 09:46 | AugustoMauch | Status | new => scheduled |
| 2023-05-15 09:43 | hgbot | Note Added: 0149691 | |
| 2023-05-15 10:02 | meriem_azaf | Status | scheduled => acknowledged |
| 2023-05-15 10:02 | meriem_azaf | Status | acknowledged => scheduled |
| 2023-08-07 13:24 | adrianromero | Note Added: 0153297 | |
| 2023-08-07 13:24 | adrianromero | Status | scheduled => resolved |
| 2023-08-07 13:24 | adrianromero | Resolution | open => fixed |
| 2023-08-07 13:25 | adrianromero | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |