Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0052418

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[POS2] Core

major

have not tried

2023-05-11 12:16

2023-05-11 17:36

Reporter

caristu

View Status

public

Assigned To

Triage Platform Base

Priority

high

Resolution

duplicate

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0052418: Errors in terminal properties are not properly managed in the UI

Description

When there is an error thrown during the calculation of the terminal properties, it is not being properly managed in react POS.

When this happens in enyo pos a dialog is displayed to the user informing about the error (see attached), and after clicking OK to close the dialog the login screen is shown again, preventing the access to the application.

Note that the problem happens when the masterdata is reloaded as part of the login, in that case the exception is catched and logged at this point[1] without providing any feedback in the UI. In case the masterdata is not refreshed during the login, the error information is correctly shown in the UI.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/core/terminal/TerminalDataMasterdataHooks.js#L54 [^]

Steps To Reproduce

1- Apply the attached patch in org.openbravo.retail.posterminal module to force an error during the calculation of the terminal properties
2- Do a fresh login in POS2, the loading gets stuck without information about the error

Proposed Solution

Manage the error also in the case of the masterdata being refreshed during the login.

Tags

No tags attached.

error-enyo-pos.png [^] (382,826 bytes) 2023-05-11 12:16

error-react-pos.png [^] (12,185 bytes) 2023-05-11 12:17

error-react-pos-correct.png [^] (21,703 bytes) 2023-05-11 12:29

forceError.diff [^] (1,090 bytes) 2023-05-11 12:33 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/posterminal/term/DeliveryPaymentMode.java b/src/org/openbravo/retail/posterminal/term/DeliveryPaymentMode.java
index 3bbcd2384..b455ee9bf 100644
--- a/src/org/openbravo/retail/posterminal/term/DeliveryPaymentMode.java
+++ b/src/org/openbravo/retail/posterminal/term/DeliveryPaymentMode.java
@@ -12,6 +12,7 @@ import javax.servlet.ServletException;
 
 import org.codehaus.jettison.json.JSONException;
 import org.codehaus.jettison.json.JSONObject;
+import org.openbravo.base.exception.OBException;
 import org.openbravo.dal.core.OBContext;
 import org.openbravo.dal.security.OrganizationStructureProvider;
 import org.openbravo.dal.service.OBDal;
@@ -27,6 +28,10 @@ public class DeliveryPaymentMode extends JSONTerminalProperty {
     JSONObject result = new JSONObject();
     OBContext.setAdminMode(true);
 
+    if (true) {
+      throw new OBException("Test Error");
+    }
+
     try {
       Organization currentOrg = OBContext.getOBContext().getCurrentOrganization();
       String deliveryPaymentMode = currentOrg.getObrdmDeliverypaymentmode();

Relationships [ Relation Graph ] [ Dependency Graph ]

duplicate of	defect	0050357		closed	meriem_azaf	POS2	OnLoginActions do not allow to display UI
related to	design defect	0051088		closed	adrianromero	Retail Modules	[Payment Limit validation] Event payment limit management should be configurable at organization or touchpoint type level
related to	defect	0052271		closed	meriem_azaf	POS2	Till is blocked if we try to access keymap editor in offline mode - when terminal still does not know that it was offline
related to	design defect	0047591		closed	cberner	POS2	Terminal model not updated in incremental refresh
related to	defect	0052423		new	Triage Platform Base	POS2	Too verbose log when an error happens in a terminal property service

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2023-05-11 12:16	caristu	New Issue
2023-05-11 12:16	caristu	Assigned To	=> Triage Platform Base
2023-05-11 12:16	caristu	Triggers an Emergency Pack	=> No
2023-05-11 12:16	caristu	Description Updated	View Revisions
2023-05-11 12:16	caristu	File Added: error-enyo-pos.png
2023-05-11 12:17	caristu	File Added: error-react-pos.png
2023-05-11 12:19	caristu	Steps to Reproduce Updated	View Revisions
2023-05-11 12:26	caristu	Proposed Solution updated
2023-05-11 12:29	caristu	Description Updated	View Revisions
2023-05-11 12:29	caristu	Steps to Reproduce Updated	View Revisions
2023-05-11 12:29	caristu	Proposed Solution updated
2023-05-11 12:29	caristu	File Added: error-react-pos-correct.png
2023-05-11 12:30	caristu	Relationship added	related to 0051088
2023-05-11 12:33	caristu	File Added: forceError.diff
2023-05-11 12:35	caristu	Relationship added	related to 0052271
2023-05-11 12:35	caristu	Relationship added	related to 0047591
2023-05-11 14:13	caristu	Issue cloned	0052423
2023-05-11 14:13	caristu	Relationship added	related to 0052423
2023-05-11 17:36	adrianromero	Relationship added	duplicate of 0050357
2023-05-11 17:36	adrianromero	Status	new => closed
2023-05-11 17:36	adrianromero	Resolution	open => duplicate

Copyright © 2000 - 2009 MantisBT Group