0052418: Errors in terminal properties are not properly managed in the UI

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0052418

POS2

Core

public

2023-05-11 12:16

2023-05-11 17:36

Reporter

caristu

Assigned To

Triage Platform Base

Priority

high

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

duplicate

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0052418: Errors in terminal properties are not properly managed in the UI

Description

When there is an error thrown during the calculation of the terminal properties, it is not being properly managed in react POS.

When this happens in enyo pos a dialog is displayed to the user informing about the error (see attached), and after clicking OK to close the dialog the login screen is shown again, preventing the access to the application.

Note that the problem happens when the masterdata is reloaded as part of the login, in that case the exception is catched and logged at this point[1] without providing any feedback in the UI. In case the masterdata is not refreshed during the login, the error information is correctly shown in the UI.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/core/terminal/TerminalDataMasterdataHooks.js#L54 [^]

Steps To Reproduce

1- Apply the attached patch in org.openbravo.retail.posterminal module to force an error during the calculation of the terminal properties
2- Do a fresh login in POS2, the loading gets stuck without information about the error

Proposed Solution

Manage the error also in the case of the masterdata being refreshed during the login.

Additional Information

Tags

No tags attached.

Relationships

duplicate of	defect	0050357	closed	meriem_azaf	POS2	OnLoginActions do not allow to display UI
related to	design defect	0051088	closed	adrianromero	Retail Modules	[Payment Limit validation] Event payment limit management should be configurable at organization or touchpoint type level
related to	defect	0052271	closed	meriem_azaf	POS2	Till is blocked if we try to access keymap editor in offline mode - when terminal still does not know that it was offline
related to	design defect	0047591	closed	cberner	POS2	Terminal model not updated in incremental refresh
related to	defect	0052423	new	Triage Platform Base	POS2	Too verbose log when an error happens in a terminal property service

Attached Files

error-enyo-pos.png (382,826) 2023-05-11 12:16
https://issues.openbravo.com/file_download.php?file_id=18517&type=bug
png

error-react-pos.png (12,185) 2023-05-11 12:17
https://issues.openbravo.com/file_download.php?file_id=18518&type=bug
png

error-react-pos-correct.png (21,703) 2023-05-11 12:29
https://issues.openbravo.com/file_download.php?file_id=18519&type=bug
png

forceError.diff (1,090) 2023-05-11 12:33
https://issues.openbravo.com/file_download.php?file_id=18520&type=bug

Issue History

Date Modified

Username

Field

Change

2023-05-11 12:16