Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050357POS2Corepublic2022-09-27 18:082023-08-07 13:25
Reporteradrianromero 
Assigned Tomeriem_azaf 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050357: OnLoginActions do not allow to display UI
DescriptionOnLoginActions are asynchronous and in cases like Fiscalization events and other events it is required to display UI dialogs. But this UI never appears and the cashier cannot interact with it because it is rendered but behind the loading panel
Steps To ReproduceRegister the following login action and verify the ask confirmation expression is reached but the console log expression is never reached and the application never ends the login action because there is a dialog behind the loading panel the cashier cannot interact with it. See the screenshots attached.

import OB from 'org.openbravo.core2/src/core/OB';
import OnLoginActions from 'org.openbravo.core2/src/core/authentication/OnLoginActions';
import './assets/style/main.scss';

export async function register() {
  OnLoginActions.registerAction(OB.EVTFIS.fiscalizationLogin);

  OnLoginActions.registerAction(async () => {
    await OB.App.View.DialogUIHandler.askConfirmation({
      title: 'Login dialog title',
      message: 'message',
      hideCancel: true
    });
    console.log('End login action.');
  });
}

export async function init() {
  // Nothing
}
Proposed SolutionThe loading panel should not be in top of all the UI it should only replace the POS application. This way dialogs and modals can be rendered on top of the loading panel.

Loading Screen component has a z-index of 2000 to be on top of all other material UI components according the change comment: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/ec4dd5ede9bbd089d3508bbd5c83a4f35c3222cf [^] This is OK fdr common components but not for modals, snackbars or tooltips See z-index for material UI components: https://mui.com/material-ui/customization/z-index/ [^]

The proposal is to change the z-index to 1250 for the Loading Screen component to be on top of regular material ui components but not for modals, snackbars or tooltips. The proposed change fixes this issue:

diff --git a/web-jspack/org.openbravo.core2/src/components/LoadingScreen/LoadingScreen.scss b/web-jspack/org.openbravo.core2/src/components/LoadingScreen/LoadingScreen.scss
index c30838ef..6fe19787 100644
--- a/web-jspack/org.openbravo.core2/src/components/LoadingScreen/LoadingScreen.scss
+++ b/web-jspack/org.openbravo.core2/src/components/LoadingScreen/LoadingScreen.scss
@@ -14,7 +14,7 @@
 
 .obc2LoadingScreen-container .obc2LoadingScreen {
   position: absolute;
- z-index: 2000; /* This screen has to be above any other element */
+ z-index: 1250; /* This screen has to be above any other element but not modals, with z-index: 1300 */
   display: grid;
   align-items: center;
   justify-items: center;
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005242923Q2.1 closed meriem_azaf OnLoginActions do not allow to display UI 
depends on backport 005243023Q1.3 closed meriem_azaf OnLoginActions do not allow to display UI 
has duplicate defect 0052418 closed Triage Platform Base Errors in terminal properties are not properly managed in the UI 
Attached Filespng loginlocked.png (179,554) 2022-09-27 18:10
https://issues.openbravo.com/file_download.php?file_id=17563&type=bug
png

png hiddingloading.png (251,144) 2022-09-27 18:11
https://issues.openbravo.com/file_download.php?file_id=17564&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-09-27 18:08adrianromeroNew Issue
2022-09-27 18:08adrianromeroAssigned To => Triage Platform Base
2022-09-27 18:08adrianromeroTriggers an Emergency Pack => No
2022-09-27 18:10adrianromeroFile Added: loginlocked.png
2022-09-27 18:11adrianromeroFile Added: hiddingloading.png
2022-09-28 16:08adrianromeroNote Added: 0141448
2023-02-28 11:08adrianromeroProposed Solution updated
2023-02-28 11:19adrianromeroProposed Solution updated
2023-05-11 17:36adrianromeroRelationship addedhas duplicate 0052418
2023-05-12 09:20AugustoMauchAssigned ToTriage Platform Base => meriem_azaf
2023-05-12 09:43hgbotNote Added: 0149653
2023-05-12 09:46AugustoMauchStatusnew => scheduled
2023-05-15 09:43hgbotNote Added: 0149691
2023-05-15 10:02meriem_azafStatusscheduled => acknowledged
2023-05-15 10:02meriem_azafStatusacknowledged => scheduled
2023-08-07 13:24adrianromeroNote Added: 0153297
2023-08-07 13:24adrianromeroStatusscheduled => resolved
2023-08-07 13:24adrianromeroResolutionopen => fixed
2023-08-07 13:25adrianromeroStatusresolved => closed

Notes
(0141448)
adrianromero   
2022-09-28 16:08   
Linked Jira ticket: https://openbravo.atlassian.net/browse/RM-3115 [^]
(0149653)
hgbot   
2023-05-12 09:43   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1094 [^]
(0149691)
hgbot   
2023-05-15 09:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1094 [^]
(0153297)
adrianromero   
2023-08-07 13:24   
https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1094 [^]