Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0004867
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 07. Sales managementminoralways2008-09-09 10:202008-12-11 13:21
ReporterrafarodaView Statuspublic 
Assigned Torafaroda 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branch2.40Fixed in SCM revision7193
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.5
OS VersionUbuntu 7.10Database version8.3Ant version1.7
Product VersionpiSCM revision7008 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0004867: 'es_ES' hardcoded in AD_COLUMN_IDENTIFIER

DescriptionIn some files, AD_COLUMN_IDENTIFIER is used, for instance, as:
AD_COLUMN_IDENTIFIER(TO_CHAR('M_Product'), TO_CHAR(T.M_PRODUCT_ID), TO_CHAR('es_ES')) in order to get the name of a product in Spanish, if this product has a translation to Spanish.

But, in the following files, TO_CHAR('es_ES') or 'es_ES' is hardcoded instead of using TO_CHAR('vars.getLanguage()') or 'vars.getLanguage()':
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportAgingBalance_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportBankJR_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalyses.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalPDF.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalyses.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesPDF.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderDimensionalPDF.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportValuationStock_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Shipment_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_process/CashBankOperations_data.xsql [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0004873 closedDowid 'es_ES' hardcoded in XSQL files 
blocks defect 0004865 closedrafaroda 'es_ES' hardcoded in AD_COLUMN_IDENTIFIER 

-  Notes
(0008988)
rafaroda (developer)
2008-09-11 11:16

 In order to test it:
1) Create a product translation for Spanish, for instance, Hammer -> Martillo ('Master Data Management || Product || Product >> Translation')
2) Then log in in Spanish (no need to install the translation) and run:
2.1) Valued Stock Report in 'Warehouse Management || Analysis Tools || Valued Stock Report'
2.2) Sales Dimensional Report (selecting Product dimension) in 'Sales Management || Analysis Tools || Sales Dimensional Report'

In both cases Hammer should appear translated as Martillo.
(0008991)
svnbot (reporter)
2008-09-11 12:05

 Repository: openbravo
Revision: 7193
Author: rafaroda
Date: 2008-09-11 12:05:41 +0200 (Thu, 11 Sep 2008)

Fixes bug 0004867 Replaced 'es_ES' by 'vars.getLanguage()' in AD_COLUMN_IDENTIFIER() functions.

---
U branches/r2.40/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql
U branches/r2.40/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Shipment_data.xsql
U branches/r2.40/src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending_data.xsql
U branches/r2.40/src/org/openbravo/erpCommon/ad_process/CashBankOperations.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_process/CashBankOperations_data.xsql
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports_data.xsql
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportAgingBalance.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportAgingBalance_data.xsql
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportBankJR.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportBankJR_data.xsql
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalyses.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalPDF.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalyses.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesPDF.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderDimensionalPDF.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportValuationStock_data.xsql
---

https://dev.openbravo.com/websvn/openbravo/?rev=7193&sc=1 [^]

- Issue History
Date Modified Username Field Change
2008-09-09 10:20 rafaroda New Issue
2008-09-09 10:20 rafaroda Assigned To => rafaroda
2008-09-09 10:20 rafaroda Status new => scheduled
2008-09-09 12:44 rafaroda Relationship added related to 0004873
2008-09-11 11:16 rafaroda Note Added: 0008988
2008-09-11 12:05 svnbot Checkin
2008-09-11 12:05 svnbot Note Added: 0008991
2008-09-11 12:05 svnbot Status scheduled => resolved
2008-09-11 12:05 svnbot Resolution open => fixed
2008-09-11 12:05 svnbot svn_revision => 7193
2008-12-11 13:21 psarobe Regression testing => No
2008-12-11 13:21 psarobe Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker