Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0004867Openbravo ERP07. Sales managementpublic2008-09-09 10:202008-12-11 13:21
rafaroda 
rafaroda 
highminoralways
closedfixed 
20Ubuntu 7.10
pi 
 
No
Core
No
0004867: 'es_ES' hardcoded in AD_COLUMN_IDENTIFIER
In some files, AD_COLUMN_IDENTIFIER is used, for instance, as:
AD_COLUMN_IDENTIFIER(TO_CHAR('M_Product'), TO_CHAR(T.M_PRODUCT_ID), TO_CHAR('es_ES')) in order to get the name of a product in Spanish, if this product has a translation to Spanish.

But, in the following files, TO_CHAR('es_ES') or 'es_ES' is hardcoded instead of using TO_CHAR('vars.getLanguage()') or 'vars.getLanguage()':
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportAgingBalance_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportBankJR_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalyses.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalPDF.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalyses.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesPDF.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderDimensionalPDF.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportValuationStock_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Shipment_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_process/CashBankOperations_data.xsql [^]
No tags attached.
related to defect 0004873 closed Dowid 'es_ES' hardcoded in XSQL files 
blocks defect 0004865 closed rafaroda 'es_ES' hardcoded in AD_COLUMN_IDENTIFIER 
Issue History
2008-09-09 10:20rafarodaNew Issue
2008-09-09 10:20rafarodaAssigned To => rafaroda
2008-09-09 10:20rafarodaStatusnew => scheduled
2008-09-09 12:44rafarodaRelationship addedrelated to 0004873
2008-09-11 11:16rafarodaNote Added: 0008988
2008-09-11 12:05svnbotCheckin
2008-09-11 12:05svnbotNote Added: 0008991
2008-09-11 12:05svnbotStatusscheduled => resolved
2008-09-11 12:05svnbotResolutionopen => fixed
2008-09-11 12:05svnbotsvn_revision => 7193
2008-12-11 13:21psarobeRegression testing => No
2008-12-11 13:21psarobeStatusresolved => closed

Notes
(0008988)
rafaroda   
2008-09-11 11:16   
In order to test it:
1) Create a product translation for Spanish, for instance, Hammer -> Martillo ('Master Data Management || Product || Product >> Translation')
2) Then log in in Spanish (no need to install the translation) and run:
2.1) Valued Stock Report in 'Warehouse Management || Analysis Tools || Valued Stock Report'
2.2) Sales Dimensional Report (selecting Product dimension) in 'Sales Management || Analysis Tools || Sales Dimensional Report'

In both cases Hammer should appear translated as Martillo.
(0008991)
svnbot   
2008-09-11 12:05   
Repository: openbravo
Revision: 7193
Author: rafaroda
Date: 2008-09-11 12:05:41 +0200 (Thu, 11 Sep 2008)

Fixes bug 0004867 Replaced 'es_ES' by 'vars.getLanguage()' in AD_COLUMN_IDENTIFIER() functions.

---
U branches/r2.40/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql
U branches/r2.40/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Shipment_data.xsql
U branches/r2.40/src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending_data.xsql
U branches/r2.40/src/org/openbravo/erpCommon/ad_process/CashBankOperations.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_process/CashBankOperations_data.xsql
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports_data.xsql
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportAgingBalance.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportAgingBalance_data.xsql
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportBankJR.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportBankJR_data.xsql
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalyses.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalPDF.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalyses.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesPDF.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderDimensionalPDF.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
U branches/r2.40/src/org/openbravo/erpCommon/ad_reports/ReportValuationStock_data.xsql
---

https://dev.openbravo.com/websvn/openbravo/?rev=7193&sc=1 [^]