Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0004865
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementminoralways2008-09-09 09:232008-11-25 23:11
ReporterrafarodaView Statuspublic 
Assigned Torafaroda 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision7207
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.5
OS VersionUbuntu 7.10Database version8.3Ant version1.7
Product VersionpiSCM revision7008 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0004865: 'es_ES' hardcoded in AD_COLUMN_IDENTIFIER

DescriptionIn some files, AD_COLUMN_IDENTIFIER is used, for instance, as:
AD_COLUMN_IDENTIFIER(TO_CHAR('M_Product'), TO_CHAR(T.M_PRODUCT_ID), TO_CHAR('es_ES')) in order to get the name of a product in Spanish, if this product has a translation to Spanish.

But, in the following files, TO_CHAR('es_ES') or 'es_ES' is hardcoded instead of using TO_CHAR('vars.getLanguage()') or 'vars.getLanguage()':
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportAgingBalance_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportBankJR_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalyses.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalPDF.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalyses.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesPDF.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderDimensionalPDF.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportValuationStock_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Shipment_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_process/CashBankOperations_data.xsql [^]
TagsNo tags attached.
Attached Filesdiff file icon ReportSalesDimensionalAnalyzeJR-bug-4865.diff [^] (1,354 bytes) 2008-09-09 09:36 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
depends on defect 0004864 closedrafaroda AD_COLUMN_IDENTIFIER does not work correctly for 'M_Product' table 
depends on backport 0004867 closedrafaroda 'es_ES' hardcoded in AD_COLUMN_IDENTIFIER 

-  Notes
(0008927)
rafaroda (developer)
2008-09-09 09:36

Patch added for ReportSalesDimensionalAnalyzeJR.java.
(0008989)
rafaroda (developer)
2008-09-11 11:16

In order to test it:
1) Create a product translation for Spanish, for instance, Hammer -> Martillo ('Master Data Management || Product || Product >> Translation')
2) Then log in in Spanish (no need to install the translation) and run:
2.1) Valued Stock Report in 'Warehouse Management || Analysis Tools || Valued Stock Report'
2.2) Sales Dimensional Report (selecting Product dimension) in 'Sales Management || Analysis Tools || Sales Dimensional Report'

In both cases Hammer should appear translated as Martillo.
(0009002)
svnbot (reporter)
2008-09-11 16:19

Repository: openbravo
Revision: 7207
Author: rafaroda
Date: 2008-09-11 16:18:42 +0200 (Thu, 11 Sep 2008)

Fixes bug 0004865 Replaced 'es_ES' by 'vars.getLanguage()' in AD_COLUMN_IDENTIFIER() functions.

---
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Shipment_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.java
U trunk/src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_process/CashBankOperations.java
U trunk/src/org/openbravo/erpCommon/ad_process/CashBankOperations_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports.java
U trunk/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportAgingBalance.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportAgingBalance_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportBankJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportBankJR_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalyses.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalPDF.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalyses.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesPDF.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderDimensionalPDF.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportValuationStock_data.xsql
---

https://dev.openbravo.com/websvn/openbravo/?rev=7207&sc=1 [^]

- Issue History
Date Modified Username Field Change
2008-09-09 09:23 rafaroda New Issue
2008-09-09 09:23 rafaroda Assigned To => cromero
2008-09-09 09:23 rafaroda sf_bug_id 0 => 2101548
2008-09-09 09:23 rafaroda Regression testing => No
2008-09-09 09:23 rafaroda Relationship added depends on 0004864
2008-09-09 09:36 rafaroda File Added: ReportSalesDimensionalAnalyzeJR-bug-4865.diff
2008-09-09 09:36 rafaroda Note Added: 0008927
2008-09-09 09:37 rafaroda Assigned To cromero => rafaroda
2008-09-09 10:14 rafaroda Summary to_char('es_ES') hardcoded in AD_COLUMN_IDENTIFIER => 'es_ES' hardcoded in AD_COLUMN_IDENTIFIER
2008-09-09 10:14 rafaroda Description Updated
2008-09-09 10:19 rafaroda Severity major => minor
2008-09-09 10:20 rafaroda Status new => scheduled
2008-09-09 10:20 rafaroda fix_in_branch => trunk
2008-09-11 11:16 rafaroda Note Added: 0008989
2008-09-11 16:19 svnbot Checkin
2008-09-11 16:19 svnbot Note Added: 0009002
2008-09-11 16:19 svnbot Status scheduled => resolved
2008-09-11 16:19 svnbot Resolution open => fixed
2008-09-11 16:19 svnbot svn_revision => 7207
2008-11-25 23:11 psarobe Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker