Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0047850
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2021-10-14 12:562021-11-08 07:32
ReportermartinsdanView Statuspublic 
Assigned Tojustin_patterson 
PriorityhighResolutionfixedFixed in VersionRR22Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version11
OS VersionUbuntu 18.04.1 LTSDatabase version10.10Ant version1.10.5
Product VersionRR21Q3.2SCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0047850: There is an hiden error processing Cashups in Errors While Importing

DescriptionWhen there is an error processing an order, the cashup, if there are fidderences, cannot be processed and the real error is hidden by another one "Couldn't enable triggers"

When creating the differences CashCloseProcessor.createDifferenceTransaction does not set the organization. Dal infrastructure will later set the Organization from the context.
If the user is logged in as * there is an error because transactions cannot be created for organization 0, then rolling back the triggers exception is raised and the real message is hiden.
Steps To ReproduceGenerate some error creating an order (use a product from other organization for example)
Do the cashup
Change the order json to import it
Logged in with organization *, process the cashup

The trigger error is shown
Proposed SolutionCashCloseProcessor.createDifferenceTransaction should set the organization, getting the legal organization from the cashup.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0048003RR21Q4.1 closedjustin_patterson There is an hiden error processing Cashups in Errors While Importing 
depends on backport 0048004RR21Q3.5 closedjustin_patterson There is an hiden error processing Cashups in Errors While Importing 

-  Notes
(0132347)
martinsdan (developer)
2021-10-14 12:57

There is a workaround:
Set the organization to the cashup organization in the user menu.
(0132641)
hgbot (developer)
2021-10-26 12:51

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/607 [^]
(0132693)
hgbot (developer)
2021-10-28 07:46

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/607 [^]
(0132694)
hgbot (developer)
2021-10-28 07:46

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 599f02eafb4d16656e26033e8752d7ef5c340892
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 2021-10-28T05:46:12+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/599f02eafb4d16656e26033e8752d7ef5c340892 [^]

Fixed ISSUE-47850: set organization within CashCloseProcessor.createDifferenceTransaction() method
- instantiate cashUpOrganization variable containing cashUp.getPOSTerminal().getOrganization() object
- set organization of transaction with cashUpOrganization value

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
---

- Issue History
Date Modified Username Field Change
2021-10-14 12:56 martinsdan New Issue
2021-10-14 12:56 martinsdan Assigned To => marvintm
2021-10-14 12:56 martinsdan Triggers an Emergency Pack => No
2021-10-14 12:57 martinsdan Assigned To marvintm => Retail
2021-10-14 12:57 martinsdan Note Added: 0132347
2021-10-25 08:26 marvintm Status new => scheduled
2021-10-25 08:26 marvintm Assigned To Retail => justin_patterson
2021-10-26 12:51 hgbot Note Added: 0132641
2021-10-28 07:46 hgbot Resolution open => fixed
2021-10-28 07:46 hgbot Status scheduled => closed
2021-10-28 07:46 hgbot Note Added: 0132693
2021-10-28 07:46 hgbot Fixed in Version => RR22Q1
2021-10-28 07:46 hgbot Note Added: 0132694
2021-11-08 07:31 marvintm Status closed => new
2021-11-08 07:31 marvintm Resolution fixed => open
2021-11-08 07:31 marvintm Fixed in Version RR22Q1 =>
2021-11-08 07:31 marvintm Status new => scheduled
2021-11-08 07:31 marvintm Status scheduled => resolved
2021-11-08 07:31 marvintm Fixed in Version => RR22Q1
2021-11-08 07:31 marvintm Resolution open => fixed
2021-11-08 07:32 marvintm Review Assigned To => marvintm
2021-11-08 07:32 marvintm Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker