Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047850Retail ModulesWeb POSpublic2021-10-14 12:562022-01-21 20:46
Reportermartinsdan 
Assigned Tojustin_patterson 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionUbuntu 18.04.1 LTS
Product VersionRR21Q3.2 
Target VersionFixed in VersionRR22Q1 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047850: There is an hiden error processing Cashups in Errors While Importing
DescriptionWhen there is an error processing an order, the cashup, if there are fidderences, cannot be processed and the real error is hidden by another one "Couldn't enable triggers"

When creating the differences CashCloseProcessor.createDifferenceTransaction does not set the organization. Dal infrastructure will later set the Organization from the context.
If the user is logged in as * there is an error because transactions cannot be created for organization 0, then rolling back the triggers exception is raised and the real message is hiden.
Steps To ReproduceGenerate some error creating an order (use a product from other organization for example)
Do the cashup
Change the order json to import it
Logged in with organization *, process the cashup

The trigger error is shown
Proposed SolutionCashCloseProcessor.createDifferenceTransaction should set the organization, getting the legal organization from the cashup.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0048003RR21Q4.1 closed justin_patterson There is an hiden error processing Cashups in Errors While Importing 
depends on backport 0048004RR21Q3.5 closed justin_patterson There is an hiden error processing Cashups in Errors While Importing 
related to backport 0048863RR18Q3.2 closed Retail There is an hiden error processing Cashups in Errors While Importing 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-10-14 12:56martinsdanNew Issue
2021-10-14 12:56martinsdanAssigned To => marvintm
2021-10-14 12:56martinsdanOBNetwork customer => OBPS
2021-10-14 12:56martinsdanTriggers an Emergency Pack => No
2021-10-14 12:57martinsdanAssigned Tomarvintm => Retail
2021-10-14 12:57martinsdanNote Added: 0132347
2021-10-25 08:26marvintmStatusnew => scheduled
2021-10-25 08:26marvintmAssigned ToRetail => justin_patterson
2021-10-26 12:51hgbotMerge Request Status => open
2021-10-26 12:51hgbotNote Added: 0132641
2021-10-28 07:46hgbotMerge Request Statusopen => approved
2021-10-28 07:46hgbotResolutionopen => fixed
2021-10-28 07:46hgbotStatusscheduled => closed
2021-10-28 07:46hgbotNote Added: 0132693
2021-10-28 07:46hgbotFixed in Version => RR22Q1
2021-10-28 07:46hgbotNote Added: 0132694
2021-11-08 07:31marvintmStatusclosed => new
2021-11-08 07:31marvintmResolutionfixed => open
2021-11-08 07:31marvintmFixed in VersionRR22Q1 =>
2021-11-08 07:31marvintmStatusnew => scheduled
2021-11-08 07:31marvintmStatusscheduled => resolved
2021-11-08 07:31marvintmFixed in Version => RR22Q1
2021-11-08 07:31marvintmResolutionopen => fixed
2021-11-08 07:32marvintmReview Assigned To => marvintm
2021-11-08 07:32marvintmStatusresolved => closed
2022-01-21 20:46eugeniIssue Monitored: eugeni
2022-03-22 01:40ivazquezRelationship addedrelated to 0048863

Notes
(0132347)
martinsdan   
2021-10-14 12:57   
There is a workaround:
Set the organization to the cashup organization in the user menu.
(0132641)
hgbot   
2021-10-26 12:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/607 [^]
(0132693)
hgbot   
2021-10-28 07:46   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/607 [^]
(0132694)
hgbot   
2021-10-28 07:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 599f02eafb4d16656e26033e8752d7ef5c340892
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 2021-10-28T05:46:12+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/599f02eafb4d16656e26033e8752d7ef5c340892 [^]

Fixed ISSUE-47850: set organization within CashCloseProcessor.createDifferenceTransaction() method
- instantiate cashUpOrganization variable containing cashUp.getPOSTerminal().getOrganization() object
- set organization of transaction with cashUpOrganization value

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
---