0048863: There is an hiden error processing Cashups in Errors While Importing

Description

When there is an error processing an order, the cash up, if there are differences, cannot be processed and the real error is hidden by another one "Couldn't enable triggers"

When creating the differences CashCloseProcessor.createDifferenceTransaction does not set the organization. Dal infrastructure will later set the Organization from the context.
If the user is logged in as * there is an error because transactions cannot be created for organization 0, then rolling back the exception of the trigger is raised and the real message is hidden.

Steps To Reproduce

Generate some error creating an order (use a product from another organization for example)
Do the cash up
Change the order JSON to import it
Logged in with organization *, process the cash up

The trigger error is shown

Proposed Solution

CashCloseProcessor.createDifferenceTransaction should set the organization, getting the legal organization from the cash up.

Tags

No tags attached.

Attached Files

18Q3.2.diff [^] (1,157 bytes) 2022-03-22 12:33 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/posterminal/CashCloseProcessor.java b/src/org/openbravo/retail/posterminal/CashCloseProcessor.java
index 654abc42603ad8338765affbe130b0e2a65e07b7..27b0857dfe3cfeba8bfd1585b0c7c259c0b265dc 100644
--- a/src/org/openbravo/retail/posterminal/CashCloseProcessor.java
+++ b/src/org/openbravo/retail/posterminal/CashCloseProcessor.java
@@ -343,6 +343,7 @@ public class CashCloseProcessor {
     }
 
     FIN_FinaccTransaction transaction = OBProvider.getInstance().get(FIN_FinaccTransaction.class);
+    Organization cashUpOrganization = cashUp.getPOSTerminal().getOrganization();
     transaction.setCurrency(account.getCurrency());
     transaction.setAccount(account);
     transaction.setLineNo(TransactionsDao.getTransactionMaxLineNo(account) + 10);
@@ -362,6 +363,9 @@ public class CashCloseProcessor {
     transaction.setObposAppCashup(cashUp);
     transaction.setDateAcct(OBMOBCUtils.stripTime(currentDate));
     transaction.setTransactionDate(OBMOBCUtils.stripTime(currentDate));
+    if (cashUpOrganization != null) {
+      transaction.setOrganization(cashUpOrganization);
+    }
 
     return transaction;
   }

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

0047850

closed

justin_patterson

There is an hiden error processing Cashups in Errors While Importing

Notes
(0135918) ivazquez (developer) 2022-03-22 12:34	Hello Team, The patch provided for version 21Q3.5 is also applicable for version 18Q3.2! Regards, Ignacio Vazquez

Issue History
Date Modified	Username	Field	Change
2022-03-22 01:40	ivazquez	New Issue
2022-03-22 01:40	ivazquez	Assigned To	=> Retail
2022-03-22 01:40	ivazquez	Triggers an Emergency Pack	=> No
2022-03-22 01:40	ivazquez	Relationship added	related to 0047850
2022-03-22 12:32	ivazquez	Resolution	open => fixed
2022-03-22 12:32	ivazquez	Fixed in Version	=> RR18Q3.2
2022-03-22 12:33	ivazquez	File Added: 18Q3.2.diff
2022-03-22 12:34	ivazquez	Note Added: 0135918
2022-04-11 13:20	ivazquez	Review Assigned To	=> AugustoMauch
2022-04-11 13:20	ivazquez	Status	new => closed