Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0048004
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajoralways2021-10-14 12:562021-11-09 12:34
ReportermartinsdanView Statuspublic 
Assigned Tojustin_patterson 
PriorityhighResolutionfixedFixed in VersionRR21Q3.5
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionRR21Q3.5
OSLinux 64 bitDatabasePostgreSQLJava version11
OS VersionUbuntu 18.04.1 LTSDatabase version10.10Ant version1.10.5
Product VersionRR21Q3.2SCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0048004: There is an hiden error processing Cashups in Errors While Importing

DescriptionWhen there is an error processing an order, the cashup, if there are fidderences, cannot be processed and the real error is hidden by another one "Couldn't enable triggers"

When creating the differences CashCloseProcessor.createDifferenceTransaction does not set the organization. Dal infrastructure will later set the Organization from the context.
If the user is logged in as * there is an error because transactions cannot be created for organization 0, then rolling back the triggers exception is raised and the real message is hiden.
Steps To ReproduceGenerate some error creating an order (use a product from other organization for example)
Do the cashup
Change the order json to import it
Logged in with organization *, process the cashup

The trigger error is shown
Proposed SolutionCashCloseProcessor.createDifferenceTransaction should set the organization, getting the legal organization from the cashup.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0047850 closedjustin_patterson There is an hiden error processing Cashups in Errors While Importing 

-  Notes
(0132890)
hgbot (developer)
2021-11-08 12:41

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/622 [^]
(0132899)
hgbot (developer)
2021-11-09 10:06

Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/622 [^]
(0132902)
hgbot (developer)
2021-11-09 10:24

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/625 [^]
(0132910)
hgbot (developer)
2021-11-09 12:34

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/625 [^]
(0132911)
hgbot (developer)
2021-11-09 12:34

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 4d9927fc4b5c6af33d5fb4c1cbec5f7bb109cd9d
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 2021-11-09T10:21:38+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/4d9927fc4b5c6af33d5fb4c1cbec5f7bb109cd9d [^]

Fixed ISSUE-48004: set organization within CashCloseProcessor.createDifferenceTransaction() method
- instantiate cashUpOrganization variable containing cashUp.getPOSTerminal().getOrganization() object
- set organization of transaction with cashUpOrganization value

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
---

- Issue History
Date Modified Username Field Change
2021-11-08 07:31 marvintm Type defect => backport
2021-11-08 07:31 marvintm Target Version => RR21Q3.5
2021-11-08 12:41 hgbot Note Added: 0132890
2021-11-09 10:06 hgbot Note Added: 0132899
2021-11-09 10:24 hgbot Note Added: 0132902
2021-11-09 12:34 hgbot Resolution open => fixed
2021-11-09 12:34 hgbot Status scheduled => closed
2021-11-09 12:34 hgbot Note Added: 0132910
2021-11-09 12:34 hgbot Fixed in Version => RR21Q3.5
2021-11-09 12:34 hgbot Note Added: 0132911


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker