Openbravo Issue Tracking System - Retail Modules
View Issue Details
0048004Retail ModulesWeb POSpublic2021-10-14 12:562021-11-09 12:34
martinsdan 
justin_patterson 
highmajoralways
closedfixed 
30Ubuntu 18.04.1 LTS
RR21Q3.2 
RR21Q3.5RR21Q3.5 
No
0048004: There is an hiden error processing Cashups in Errors While Importing
When there is an error processing an order, the cashup, if there are fidderences, cannot be processed and the real error is hidden by another one "Couldn't enable triggers"

When creating the differences CashCloseProcessor.createDifferenceTransaction does not set the organization. Dal infrastructure will later set the Organization from the context.
If the user is logged in as * there is an error because transactions cannot be created for organization 0, then rolling back the triggers exception is raised and the real message is hiden.
Generate some error creating an order (use a product from other organization for example)
Do the cashup
Change the order json to import it
Logged in with organization *, process the cashup

The trigger error is shown
CashCloseProcessor.createDifferenceTransaction should set the organization, getting the legal organization from the cashup.
No tags attached.
blocks defect 0047850 closed justin_patterson There is an hiden error processing Cashups in Errors While Importing 
Issue History
2021-11-08 07:31marvintmTypedefect => backport
2021-11-08 07:31marvintmTarget Version => RR21Q3.5
2021-11-08 12:41hgbotNote Added: 0132890
2021-11-09 10:06hgbotNote Added: 0132899
2021-11-09 10:24hgbotNote Added: 0132902
2021-11-09 12:34hgbotResolutionopen => fixed
2021-11-09 12:34hgbotStatusscheduled => closed
2021-11-09 12:34hgbotNote Added: 0132910
2021-11-09 12:34hgbotFixed in Version => RR21Q3.5
2021-11-09 12:34hgbotNote Added: 0132911

Notes
(0132890)
hgbot   
2021-11-08 12:41   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/622 [^]
(0132899)
hgbot   
2021-11-09 10:06   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/622 [^]
(0132902)
hgbot   
2021-11-09 10:24   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/625 [^]
(0132910)
hgbot   
2021-11-09 12:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/625 [^]
(0132911)
hgbot   
2021-11-09 12:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 4d9927fc4b5c6af33d5fb4c1cbec5f7bb109cd9d
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 2021-11-09T10:21:38+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/4d9927fc4b5c6af33d5fb4c1cbec5f7bb109cd9d [^]

Fixed ISSUE-48004: set organization within CashCloseProcessor.createDifferenceTransaction() method
- instantiate cashUpOrganization variable containing cashUp.getPOSTerminal().getOrganization() object
- set organization of transaction with cashUpOrganization value

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
---