Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0046952
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2021-06-02 13:122021-06-04 07:59
ReportermarvintmView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR21Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2020-06-11
Regression introduced in releaseRR20Q4
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/342be60966656fa86b620a0428e632d4b53ffb1f [^]
Triggers an Emergency PackNo
Summary

0046952: Order creationDate is not correctly set

DescriptionCurrently the creationDate of orders generated from the POS is not correctly set. It should always be set to the moment in which the order is completed. Instead, it is set to the moment in which the order is initialised in the frontend.

This is wrong in all cases, but it is particularly visible if the user completes an order one day and then leaves, and the next day he logs in the system, adds products and completes another order, as this last order will have creationDate from the day before.
Steps To Reproduce- Log in the POS. Add some products and complete the order (so that a new order is created).
- Add some products and wait some minutes.
- Complete the order.
- Check the backend. Realise that the creationDate of the order is not the moment when it was completed, but when it was created.
Proposed SolutionThe problem seems to be that the creationDate is being initialised when the order is initialised, and then it is not overwritten by the ticket completion process. Checking the previous version before the indexedDB change, the order did not acquire creationDate until after it was completed, and we should probably replicate this behaviour.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0046953TAP closedranjith_qualiantech_com POS2 Order creationDate is not correctly set 
depends on backport 0046954RR21Q2.1 closedranjith_qualiantech_com Retail Modules Order creationDate is not correctly set 
depends on backport 0046955RR21Q1.3 closedranjith_qualiantech_com Retail Modules Order creationDate is not correctly set 
depends on backport 0046956RR20Q4.5 closedranjith_qualiantech_com Retail Modules Order creationDate is not correctly set 

-  Notes
(0128978)
hgbot (developer)
2021-06-03 07:49

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/453 [^]
(0129045)
hgbot (developer)
2021-06-04 07:59

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/453 [^]
(0129046)
hgbot (developer)
2021-06-04 07:59

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d32fe8e2f9ff909878cc3096bba0f3a01e2c4d8d
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-06-04T05:58:36+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d32fe8e2f9ff909878cc3096bba0f3a01e2c4d8d [^]

Fixed ISSUE-46952: Order creationDate should be updated when completing it

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CreateCancelTicket.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/ReactivateQuotation.js
M web/org.openbravo.retail.posterminal/js/components/orderdetails.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---

- Issue History
Date Modified Username Field Change
2021-06-02 13:12 marvintm New Issue
2021-06-02 13:12 marvintm Assigned To => Retail
2021-06-02 13:12 marvintm OBNetwork customer => No
2021-06-02 13:12 marvintm Triggers an Emergency Pack => No
2021-06-02 13:16 marvintm OBNetwork customer No => Gold
2021-06-02 13:16 marvintm Resolution time => 1623276000
2021-06-02 13:16 marvintm Regression level => Production - Confirmed Stable
2021-06-02 13:16 marvintm Regression date => 2020-06-11
2021-06-02 13:16 marvintm Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/342be60966656fa86b620a0428e632d4b53ffb1f [^]
2021-06-02 13:16 marvintm Status new => scheduled
2021-06-02 13:16 marvintm Project POS2 => Retail Modules
2021-06-02 13:16 marvintm Status scheduled => acknowledged
2021-06-02 13:17 marvintm Regression introduced in release => RR20Q4
2021-06-02 13:17 marvintm Category POS => Adyen
2021-06-02 13:17 marvintm Status acknowledged => scheduled
2021-06-02 13:18 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2021-06-02 13:45 marvintm Category Adyen => Web POS
2021-06-03 07:49 hgbot Merge Request Status => open
2021-06-03 07:49 hgbot Note Added: 0128978
2021-06-04 07:58 hgbot Merge Request Status open => approved
2021-06-04 07:59 hgbot Resolution open => fixed
2021-06-04 07:59 hgbot Status scheduled => closed
2021-06-04 07:59 hgbot Note Added: 0129045
2021-06-04 07:59 hgbot Fixed in Version => RR21Q3
2021-06-04 07:59 hgbot Note Added: 0129046

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker