Openbravo Issue Tracking System - Retail Modules
View Issue Details
0046952Retail ModulesWeb POSpublic2021-06-02 13:122021-06-04 07:59
marvintm 
ranjith_qualiantech_com 
normalmajoralways
closedfixed 
5
 
RR21Q3 
Production - Confirmed Stable
2020-06-11
RR20Q4
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/342be60966656fa86b620a0428e632d4b53ffb1f [^]
No
0046952: Order creationDate is not correctly set
Currently the creationDate of orders generated from the POS is not correctly set. It should always be set to the moment in which the order is completed. Instead, it is set to the moment in which the order is initialised in the frontend.

This is wrong in all cases, but it is particularly visible if the user completes an order one day and then leaves, and the next day he logs in the system, adds products and completes another order, as this last order will have creationDate from the day before.
- Log in the POS. Add some products and complete the order (so that a new order is created).
- Add some products and wait some minutes.
- Complete the order.
- Check the backend. Realise that the creationDate of the order is not the moment when it was completed, but when it was created.
The problem seems to be that the creationDate is being initialised when the order is initialised, and then it is not overwritten by the ticket completion process. Checking the previous version before the indexedDB change, the order did not acquire creationDate until after it was completed, and we should probably replicate this behaviour.
No tags attached.
depends on backport 0046953TAP closed ranjith_qualiantech_com POS2 Order creationDate is not correctly set 
depends on backport 0046954RR21Q2.1 closed ranjith_qualiantech_com Retail Modules Order creationDate is not correctly set 
depends on backport 0046955RR21Q1.3 closed ranjith_qualiantech_com Retail Modules Order creationDate is not correctly set 
depends on backport 0046956RR20Q4.5 closed ranjith_qualiantech_com Retail Modules Order creationDate is not correctly set 
Issue History
2021-06-02 13:12marvintmNew Issue
2021-06-02 13:12marvintmAssigned To => Retail
2021-06-02 13:12marvintmTriggers an Emergency Pack => No
2021-06-02 13:16marvintmResolution time => 1623276000
2021-06-02 13:16marvintmRegression level => Production - Confirmed Stable
2021-06-02 13:16marvintmRegression date => 2020-06-11
2021-06-02 13:16marvintmRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/342be60966656fa86b620a0428e632d4b53ffb1f [^]
2021-06-02 13:16marvintmStatusnew => scheduled
2021-06-02 13:16marvintmProjectPOS2 => Retail Modules
2021-06-02 13:16marvintmStatusscheduled => acknowledged
2021-06-02 13:17marvintmRegression introduced in release => RR20Q4
2021-06-02 13:17marvintmCategoryPOS => Adyen
2021-06-02 13:17marvintmStatusacknowledged => scheduled
2021-06-02 13:18ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-06-02 13:45marvintmCategoryAdyen => Web POS
2021-06-03 07:49hgbotNote Added: 0128978
2021-06-04 07:59hgbotResolutionopen => fixed
2021-06-04 07:59hgbotStatusscheduled => closed
2021-06-04 07:59hgbotNote Added: 0129045
2021-06-04 07:59hgbotFixed in Version => RR21Q3
2021-06-04 07:59hgbotNote Added: 0129046

Notes
(0128978)
hgbot   
2021-06-03 07:49   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/453 [^]
(0129045)
hgbot   
2021-06-04 07:59   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/453 [^]
(0129046)
hgbot   
2021-06-04 07:59   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d32fe8e2f9ff909878cc3096bba0f3a01e2c4d8d
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-06-04T05:58:36+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d32fe8e2f9ff909878cc3096bba0f3a01e2c4d8d [^]

Fixed ISSUE-46952: Order creationDate should be updated when completing it

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CreateCancelTicket.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/ReactivateQuotation.js
M web/org.openbravo.retail.posterminal/js/components/orderdetails.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---