Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0046955
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Adyenmajoralways2021-06-02 13:122021-06-07 07:15
ReportermarvintmView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR21Q1.3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionRR21Q1.3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression levelProduction - Confirmed Stable
Regression date2020-06-11
Regression introduced in releaseRR20Q4
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/342be60966656fa86b620a0428e632d4b53ffb1f [^]
Triggers an Emergency PackNo
Summary

0046955: Order creationDate is not correctly set

DescriptionCurrently the creationDate of orders generated from the POS is not correctly set. It should always be set to the moment in which the order is completed. Instead, it is set to the moment in which the order is initialised in the frontend.

This is wrong in all cases, but it is particularly visible if the user completes an order one day and then leaves, and the next day he logs in the system, adds products and completes another order, as this last order will have creationDate from the day before.
Steps To Reproduce- Log in the POS. Add some products and complete the order (so that a new order is created).
- Add some products and wait some minutes.
- Complete the order.
- Check the backend. Realise that the creationDate of the order is not the moment when it was completed, but when it was created.
Proposed SolutionThe problem seems to be that the creationDate is being initialised when the order is initialised, and then it is not overwritten by the ticket completion process. Checking the previous version before the indexedDB change, the order did not acquire creationDate until after it was completed, and we should probably replicate this behaviour.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0046952 closedranjith_qualiantech_com Order creationDate is not correctly set 

-  Notes
(0129097)
hgbot (developer)
2021-06-07 04:03

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/461 [^]
(0129110)
hgbot (developer)
2021-06-07 07:15

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/461 [^]
(0129111)
hgbot (developer)
2021-06-07 07:15

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 5f16d450c981a4384b7dc70011af49084853abb3
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-06-06T19:55:30+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/5f16d450c981a4384b7dc70011af49084853abb3 [^]

Fixed ISSUE-46955: Order creationDate should be updated when completing it

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/ReactivateQuotation.js
M web/org.openbravo.retail.posterminal/js/components/orderdetails.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---

- Issue History
Date Modified Username Field Change
2021-06-02 13:17 marvintm Type defect => backport
2021-06-02 13:17 marvintm Target Version => RR21Q1.3
2021-06-04 08:00 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2021-06-07 04:03 hgbot Note Added: 0129097
2021-06-07 07:15 hgbot Note Added: 0129110
2021-06-07 07:15 hgbot Resolution open => fixed
2021-06-07 07:15 hgbot Status scheduled => closed
2021-06-07 07:15 hgbot Fixed in Version => RR21Q1.3
2021-06-07 07:15 hgbot Note Added: 0129111


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker