Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0046648
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POScriticalalways2021-05-12 16:362021-05-26 14:01
ReporterpsanjuanView Statuspublic 
Assigned Togorka_gil 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046648: Cash Process does not create the G/L item for cash up transaction

DescriptionCash Process does not create the G/L item for cash up transaction

EDIT:
Apart of the problem explained in this issue, there is another two problems related:
- https://issues.openbravo.com/view.php?id=46692 [^]
- https://issues.openbravo.com/view.php?id=46739 [^]
Marked as duplicated because the fix is the same
Steps To ReproduceRun a cash process to close all pending receipts.

Create a POS receipt for an amount of 18€. Pay it in cash.

Go to backoffice and verify that the corresponding sales order has been created with Invoice Status = 0%

Navigate to the financial account (POS2SD Cashbook - Vall Blanca Store - VBS2) and verify there is a transaction created in there with below details:

BP Deposit
Transaction date = 12/05/2021
Deposit Amount = 18

Run cash up process and match the amounts. Do not keep any cash amount.

Navigate once more to the financial account (cash book financial account of the terminal) and verify that no Withdrawal transaction has been created in there to move that cash up balance to the corresponding back office Financial Account of the store (Cashbook - Vall Blanca Backoffice).

Navigate to the reconciliation tab, and filter by the current date, then go to Cleared Items sub-tab. Verify that the reconciliation only includes one line

Navigate to the corresponding backoffice financial account (Cashbook - Vall Blanca Backoffice) and verify that no deposit transaction related to the same GL item has been created in there with cash up amount.

See screens attached for both livebuilds and new POS results.

EDIT:
To these steps to reproduce is also needed to add the ones in these issues:
- https://issues.openbravo.com/view.php?id=46692 [^]
- https://issues.openbravo.com/view.php?id=46739 [^]
Proposed SolutionA matching transaction needs to be created in the cash book account to withdraw cash up amount, to deposit that amount in the backoffice account of the store.



The problem seems to be that although the "expected" property is correctly set, the "foreignExpected" property is not, and finally it is this "foreignExpected" property the one that is used in the CashCloseProcessor.java (line 128) to calculate the reconciliationTotal. If this amount is set to 0, then no transaction to move the money out of the till is generated.

The solution therefore is to set this "foreignExpected" property inside the "cashCloseInfo" object inside the Cashup data to the proper value. Once this is done it seems the transaction will be generated correctly.
TagsNo tags attached.
Attached Filespng file icon CashBookNewPOS.png [^] (219,787 bytes) 2021-05-12 16:52


png file icon CashBookReconciliationNewPOS.png [^] (162,670 bytes) 2021-05-12 16:53


png file icon BackofficeFANewPOS.png [^] (174,789 bytes) 2021-05-12 16:53


png file icon CashBookLivebuilds.png [^] (174,986 bytes) 2021-05-12 16:54


png file icon ReconciliationLiveBuilds.png [^] (168,636 bytes) 2021-05-12 16:54


png file icon BackofficeFA_Livebuilds.png [^] (190,505 bytes) 2021-05-12 16:54

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0046663TAP closedgorka_gil Cash Process does not create the G/L item for cash up transaction 
has duplicate defect 0046692 closedgorka_gil Reconciliation not correct after a Cash up 
has duplicate defect 0046739 closedgorka_gil Cash up differences are not created 
has duplicate backport 0046748TAP closedgorka_gil Cash up differences are not created 

-  Notes
(0128495)
hgbot (developer)
2021-05-21 13:42

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/480 [^]
(0128658)
hgbot (developer)
2021-05-26 13:11

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/480 [^]
(0128659)
hgbot (developer)
2021-05-26 13:11

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c3fa865795e6481c04ee2a838c326ab3a1150886
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2021-05-26T11:09:42+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c3fa865795e6481c04ee2a838c326ab3a1150886 [^]

Fixed ISSUE-46648: fix missing G/L item for cashup

Fixed values of foreignExpected and foreignDifference when sending the cashup

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/MatchCountedWithExpected.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/OpenCashup.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetCountedAmount.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetSplitMergeCoinsAndNotes.js
---
(0128664)
hgbot (developer)
2021-05-26 14:01

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: da427359a21bdf1b2363a98dfa12050babebbaeb
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2021-05-26T14:01:05+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/da427359a21bdf1b2363a98dfa12050babebbaeb [^]

Related to ISSUE-46648: fix test MatchCountedWithExpected

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/MatchCountedWithExpected.test.js
---

- Issue History
Date Modified Username Field Change
2021-05-12 16:36 psanjuan New Issue
2021-05-12 16:36 psanjuan Assigned To => Retail
2021-05-12 16:36 psanjuan Triggers an Emergency Pack => No
2021-05-12 16:45 psanjuan Steps to Reproduce Updated View Revisions
2021-05-12 16:49 psanjuan Steps to Reproduce Updated View Revisions
2021-05-12 16:52 psanjuan Steps to Reproduce Updated View Revisions
2021-05-12 16:52 psanjuan Proposed Solution updated
2021-05-12 16:52 psanjuan File Added: CashBookNewPOS.png
2021-05-12 16:53 psanjuan File Added: CashBookReconciliationNewPOS.png
2021-05-12 16:53 psanjuan File Added: BackofficeFANewPOS.png
2021-05-12 16:54 psanjuan File Added: CashBookLivebuilds.png
2021-05-12 16:54 psanjuan File Added: ReconciliationLiveBuilds.png
2021-05-12 16:54 psanjuan File Added: BackofficeFA_Livebuilds.png
2021-05-12 16:56 psanjuan Steps to Reproduce Updated View Revisions
2021-05-12 16:57 psanjuan Resolution time => 1622412000
2021-05-13 16:13 marvintm Severity major => critical
2021-05-13 16:13 marvintm Description Updated View Revisions
2021-05-13 16:13 marvintm Proposed Solution updated
2021-05-13 16:14 marvintm Resolution time 1622412000 => 1621202400
2021-05-13 16:15 marvintm Status new => acknowledged
2021-05-13 16:16 marvintm Status acknowledged => scheduled
2021-05-13 16:16 marvintm Status scheduled => acknowledged
2021-05-17 18:26 pablobessone Assigned To Retail => pablobessone
2021-05-17 18:26 pablobessone Status acknowledged => scheduled
2021-05-19 06:52 marvintm Relationship added related to 0046692
2021-05-19 15:30 gorka_gil Assigned To pablobessone => gorka_gil
2021-05-21 13:42 hgbot Note Added: 0128495
2021-05-24 18:26 gorka_gil Relationship added has duplicate 0046739
2021-05-24 18:26 gorka_gil Relationship added has duplicate 0046748
2021-05-24 18:26 gorka_gil Relationship replaced has duplicate 0046692
2021-05-24 18:30 gorka_gil Description Updated View Revisions
2021-05-24 18:30 gorka_gil Steps to Reproduce Updated View Revisions
2021-05-26 13:11 hgbot Note Added: 0128658
2021-05-26 13:11 hgbot Resolution open => fixed
2021-05-26 13:11 hgbot Status scheduled => closed
2021-05-26 13:11 hgbot Note Added: 0128659
2021-05-26 14:01 hgbot Note Added: 0128664

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker