Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045931
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 00. Application dictionarymajoralways2021-02-20 14:322021-03-24 07:31
Reporterneil_smithView Statuspublic 
Assigned Tocberner 
PriorityimmediateResolutionfixedFixed in VersionPR21Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression levelProduction - QA Approved
Regression date2020-11-27
Regression introduced in releasePR21Q1
Regression introduced by commithttps://gitlab.com/openbravo/product/openbravo/-/commit/809d27effffdab2849401ef6ae46b0887286d4f3#7ecaebbbea2c3445dde3c7bf33d33a14aff5dd7e_128_127 [^]
Triggers an Emergency PackNo
Summary

0045931: Create Fields button in Window, tabs and fields-Tab not working (0 fields created)

DescriptionIt is not possible to create fields in a tab anymore using the 'Create Fields' procedure (AD_TAB_IMPORT0)
Steps To ReproduceCreate a window with a tab based on the C_BPARTNER table for example.
Click on button 'Create Fields'
-> 0 Fields created
Proposed SolutionThe problem is in the AD_TAB_IMPORT function.

You added a join on the USER_TAB_COLUMNS in last version and you do a join on the name of the table and name of the column

In the USER_TAB_COLUMN, all the names (tablename and columnname) are uppercased!

When you join on the tablename and columnname, use UPPER() on both.
-> utc.table_name = UPPER(t.tablename) AND utc.column_name = UPPER(c.Columnname)

I can only guess that this change was not tested at all... The only way to make it work would be that the table name and column names would all be in uppercase in the dictionnary (and it is not the case)
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0046126PR21Q1.1 closedcberner Create Fields button in Window, tabs and fields-Tab not working (0 fields created) 
caused by feature request 0044155 closedplatform Make DBSM support Postgres tsvector column 

-  Notes
(0126850)
hgbot (developer)
2021-03-23 13:57

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/335 [^]
(0126873)
hgbot (developer)
2021-03-24 07:31

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/335 [^]
(0126874)
hgbot (developer)
2021-03-24 07:31

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 63037b074faa4b3dfa847e9b6f3bbd5bf1da2a1b
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2021-03-24T06:09:41+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/63037b074faa4b3dfa847e9b6f3bbd5bf1da2a1b [^]

Fixes ISSUE-45931: Create Fields button in Window -> tabs not working (0 fields created)

This issue was due to a modification on the selection query to detect
which fields should be added, from the columns of the underlying table.
A new join was added with table user_tab_column, but it was incorrect,
as one part of it was always in upper case, while the other part was not.

To fix it, an UPPER() function has been added to the corresponding where
clauses that required it.

Fixes regression introduced by commit 809d27effffdab2849401ef6ae46b0887286d4f3

---
M src-db/database/model/functions/AD_TAB_IMPORT.xml
---

- Issue History
Date Modified Username Field Change
2021-02-20 14:32 neil_smith New Issue
2021-02-20 14:32 neil_smith Assigned To => platform
2021-02-20 14:32 neil_smith Modules => Core
2021-02-20 14:32 neil_smith Triggers an Emergency Pack => No
2021-03-23 13:36 cberner Assigned To platform => cberner
2021-03-23 13:40 cberner Regression level => Production - QA Approved
2021-03-23 13:40 cberner Regression date => 2020-11-27
2021-03-23 13:40 cberner Regression introduced in release => PR21Q1
2021-03-23 13:40 cberner Regression introduced by commit => https://gitlab.com/openbravo/product/openbravo/-/commit/809d27effffdab2849401ef6ae46b0887286d4f3#7ecaebbbea2c3445dde3c7bf33d33a14aff5dd7e_128_127 [^]
2021-03-23 13:40 cberner Severity critical => major
2021-03-23 13:57 hgbot Note Added: 0126850
2021-03-24 06:54 alostale Relationship added caused by 0044155
2021-03-24 07:00 alostale Status new => scheduled
2021-03-24 07:31 hgbot Note Added: 0126873
2021-03-24 07:31 hgbot Resolution open => fixed
2021-03-24 07:31 hgbot Status scheduled => closed
2021-03-24 07:31 hgbot Fixed in Version => PR21Q2
2021-03-24 07:31 hgbot Note Added: 0126874

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker