Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0046126 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
backport | [Openbravo ERP] 00. Application dictionary | major | always | 2021-02-20 14:32 | 2021-03-24 11:33 | |||
Reporter | neil_smith | View Status | public | |||||
Assigned To | cberner | |||||||
Priority | immediate | Resolution | fixed | Fixed in Version | PR21Q1.1 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | PR21Q1.1 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Web browser | ||||||||
Modules | Core | |||||||
Regression level | Production - QA Approved | |||||||
Regression date | 2020-11-27 | |||||||
Regression introduced in release | PR21Q1 | |||||||
Regression introduced by commit | https://gitlab.com/openbravo/product/openbravo/-/commit/809d27effffdab2849401ef6ae46b0887286d4f3#7ecaebbbea2c3445dde3c7bf33d33a14aff5dd7e_128_127 [^] | |||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0046126: Create Fields button in Window, tabs and fields-Tab not working (0 fields created) | |||||||
Description | It is not possible to create fields in a tab anymore using the 'Create Fields' procedure (AD_TAB_IMPORT0) | |||||||
Steps To Reproduce | Create a window with a tab based on the C_BPARTNER table for example. Click on button 'Create Fields' -> 0 Fields created | |||||||
Proposed Solution | The problem is in the AD_TAB_IMPORT function. You added a join on the USER_TAB_COLUMNS in last version and you do a join on the name of the table and name of the column In the USER_TAB_COLUMN, all the names (tablename and columnname) are uppercased! When you join on the tablename and columnname, use UPPER() on both. -> utc.table_name = UPPER(t.tablename) AND utc.column_name = UPPER(c.Columnname) I can only guess that this change was not tested at all... The only way to make it work would be that the table name and column names would all be in uppercase in the dictionnary (and it is not the case) | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||
|
Notes | |
(0126882) hgbot (developer) 2021-03-24 10:45 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/336 [^] |
(0126885) hgbot (developer) 2021-03-24 11:32 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/336 [^] |
(0126886) hgbot (developer) 2021-03-24 11:33 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 4995abb2b749eaac4007ed5fdd1932c9a1e5adba Author: Cristian Berner <cristian.berner@openbravo.com> Date: 2021-03-24T10:44:01+01:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/4995abb2b749eaac4007ed5fdd1932c9a1e5adba [^] Fixes ISSUE-46126: Create Fields button in Window -> tabs not working (0 fields created) This issue was due to a modification on the selection query to detect which fields should be added, from the columns of the underlying table. A new join was added with table user_tab_column, but it was incorrect, as one part of it was always in upper case, while the other part was not. To fix it, an UPPER() function has been added to the corresponding where clauses that required it. Fixes regression introduced by commit 809d27effffdab2849401ef6ae46b0887286d4f3 --- M src-db/database/model/functions/AD_TAB_IMPORT.xml --- |
Issue History | |||
Date Modified | Username | Field | Change |
2021-03-24 07:00 | alostale | Type | defect => backport |
2021-03-24 07:00 | alostale | Target Version | => PR21Q1.1 |
2021-03-24 10:45 | hgbot | Note Added: 0126882 | |
2021-03-24 11:32 | hgbot | Note Added: 0126885 | |
2021-03-24 11:33 | hgbot | Resolution | open => fixed |
2021-03-24 11:33 | hgbot | Status | scheduled => closed |
2021-03-24 11:33 | hgbot | Fixed in Version | => PR21Q1.1 |
2021-03-24 11:33 | hgbot | Note Added: 0126886 |
Copyright © 2000 - 2009 MantisBT Group |