Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045597
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2020-12-17 06:422020-12-17 06:45
ReportermarvintmView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionfixedFixed in VersionRR20Q3.3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045597: API change: method getcssFileList() has been removed from manifest classes

DescriptionThe manifest generator classes ( and ) previously had a method called getcssFileList(). We have removed it, as it just added all CSS files blindly to the manifest, and this was useless and wrong.

The reason it was useless is that CSS files are added to the main StyleSheetComponent, and there they are properly minimised and attached in the correct order. The manifest then just loaded them separately, but the application never requested those files separately, so it was just a waste of network bandwidth without any reason.
Steps To Reproduce.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0045561 closedranjith_qualiantech_com Service workers infrastructure precaches CSS files that are then never used 

-  Notes
(0124893)
hgbot (developer)
2020-12-17 06:44

 Repository: https://gitlab.com/openbravo/ci/mobile-api [^]
Changeset: c6821711d5301a33f81d7c422c57f83333282702
Author: Antonio Moreno <anmorenoperez@gmail.com>
Date: 2020-12-17T06:44:20+01:00
URL: https://gitlab.com/openbravo/ci/mobile-api/-/commit/c6821711d5301a33f81d7c422c57f83333282702 [^]

Fixed ISSUE-45597: Method getcssFileList has been removed from manifest generating classes.
This method just blindly added all CSS files to the manifest. This meant that they were then precached automatically by the service workers cache. However, this was never needed, as the CSS files are actually included inside the separate StyleSheetResourceComponent request, and therefore we were basically loading them twice.

---
M java/reference/java.japi.gz
---

- Issue History
Date Modified Username Field Change
2020-12-17 06:42 marvintm New Issue
2020-12-17 06:42 marvintm Assigned To => Retail
2020-12-17 06:42 marvintm OBNetwork customer => No
2020-12-17 06:42 marvintm Triggers an Emergency Pack => No
2020-12-17 06:42 marvintm Relationship added related to 0045561
2020-12-17 06:44 hgbot Resolution open => fixed
2020-12-17 06:44 hgbot Status new => resolved
2020-12-17 06:44 hgbot Note Added: 0124893
2020-12-17 06:45 marvintm Review Assigned To => marvintm
2020-12-17 06:45 marvintm Status resolved => closed
2020-12-17 06:45 marvintm Fixed in Version => RR21Q1
2020-12-17 06:45 marvintm Fixed in Version RR21Q1 => RR20Q3.3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker