Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0045561 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | major | have not tried | 2020-12-14 08:29 | 2020-12-17 03:34 | |||
Reporter | marvintm | View Status | public | |||||
Assigned To | ranjith_qualiantech_com | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | RR21Q1 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | approved | |||||||
Review Assigned To | ||||||||
OBNetwork customer | Gold | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0045561: Service workers infrastructure precaches CSS files that are then never used | |||||||
Description | Currently there is code inside the Service workers/AppCacheManifest infrastructure that adds CSS files belonging to external modules automatically to the Manifest as separate requests: MobileCoreApplicationCacheComponent.java: method getcssFileList() cache-manifest-ftl <#list data.cssFileList as cssFile> ${cssFile} </#list> This causes the Service Worker to request and store those files separately. However, the WebPOS application then never formally requests them, as their content is already present inside the main StyleSheetResources request. Therefore, we are wasting quite a bit of bandwidth and triggering many unnecessary requests. | |||||||
Steps To Reproduce | Go to livebuilds and access the modules instance. Check in developer tools and see that many css requests exist separately, coming from the Service Worker. Then reload the page (F5), and realise that those css files are never actually requested by the application. | |||||||
Proposed Solution | Delete both the getcssFileList method inside MobileCoreApplicationCacheComponent.java and the corresponding CSS section inside cache-manifest-ftl | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() ![]() ![]() ![]() | |||||||
![]() |
||||||||||||||||||||||
|
![]() |
|
(0124848) hgbot (developer) 2020-12-16 06:48 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/112 [^] |
(0124849) hgbot (developer) 2020-12-16 06:48 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary/-/merge_requests/6 [^] |
(0124861) hgbot (developer) 2020-12-16 08:09 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/112 [^] |
(0124862) hgbot (developer) 2020-12-16 08:09 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 173c9b82f1029ebcaaf442d75a83017bed2b8daa Author: Ranjith S R <ranjith@qualiantech.com> Date: 2020-12-15T21:45:27+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/173c9b82f1029ebcaaf442d75a83017bed2b8daa [^] Fixed ISSUE-45561: Removed CSS Componenet in Cache Component --- M src/org/openbravo/mobile/core/BaseCoreAppCacheResourceProvider.java M src/org/openbravo/mobile/core/MobileCoreApplicationCacheComponent.java M src/org/openbravo/mobile/core/templates/cache-manifest.ftl --- |
(0124863) hgbot (developer) 2020-12-16 08:09 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary [^] Changeset: 1eb125eabbf8c86ff4f26731c9c550f16e7f6fc6 Author: Ranjith S R <ranjith@qualiantech.com> Date: 2020-12-15T15:29:38+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary/-/commit/1eb125eabbf8c86ff4f26731c9c550f16e7f6fc6 [^] Related to ISSUE-45561: Removed CSS Componenet in Cache Component Provider --- M src/org/openbravo/retail/complementary/ComplementaryAppCacheProvider.java --- |
(0124864) hgbot (developer) 2020-12-16 08:09 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary/-/merge_requests/6 [^] |
(0124880) hgbot (developer) 2020-12-16 12:12 |
Repository: https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.mobile.warehouse [^] Changeset: 9cb274f3aad2f4c58596a96880a229e99e5f9610 Author: Ranjith S R <ranjith@qualiantech.com> Date: 2020-12-15T15:29:47+05:30 URL: https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.mobile.warehouse/-/commit/9cb274f3aad2f4c58596a96880a229e99e5f9610 [^] Related to ISSUE-45561: Removed CSS Componenet in Cache Component Provider --- M src/org/openbravo/mobile/warehouse/WarehouseApplicationCacheComponent.java --- |
(0124881) hgbot (developer) 2020-12-16 12:12 |
Merge request merged: https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.mobile.warehouse/-/merge_requests/1 [^] |
(0124882) hgbot (developer) 2020-12-16 12:12 |
Repository: https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.mobile.procurement [^] Changeset: 665b15c75dc3503bf07ce5eff57239f43235b655 Author: Ranjith S R <ranjith@qualiantech.com> Date: 2020-12-15T15:29:53+05:30 URL: https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.mobile.procurement/-/commit/665b15c75dc3503bf07ce5eff57239f43235b655 [^] Related to ISSUE-45561: Removed CSS Componenet in Cache Component Provider --- M src/org/openbravo/mobile/procurement/ProcurementApplicationCacheComponent.java --- |
(0124883) hgbot (developer) 2020-12-16 12:12 |
Merge request merged: https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.mobile.procurement/-/merge_requests/1 [^] |
![]() |
|||
Date Modified | Username | Field | Change |
2020-12-14 08:29 | marvintm | New Issue | |
2020-12-14 08:29 | marvintm | Assigned To | => Retail |
2020-12-14 08:29 | marvintm | OBNetwork customer | => Gold |
2020-12-14 08:29 | marvintm | Resolution time | => 1609714800 |
2020-12-14 08:29 | marvintm | Triggers an Emergency Pack | => No |
2020-12-14 11:16 | shuehner | Status | new => scheduled |
2020-12-14 11:16 | shuehner | Issue Monitored: shuehner | |
2020-12-15 04:54 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
2020-12-16 06:48 | hgbot | Merge Request Status | => open |
2020-12-16 06:48 | hgbot | Note Added: 0124848 | |
2020-12-16 06:48 | hgbot | Note Added: 0124849 | |
2020-12-16 06:48 | hgbot | Note Added: 0124850 | |
2020-12-16 06:48 | hgbot | Note Added: 0124851 | |
2020-12-16 08:08 | hgbot | Merge Request Status | open => approved |
2020-12-16 08:09 | hgbot | Resolution | open => fixed |
2020-12-16 08:09 | hgbot | Status | scheduled => closed |
2020-12-16 08:09 | hgbot | Note Added: 0124861 | |
2020-12-16 08:09 | hgbot | Fixed in Version | => RR21Q1 |
2020-12-16 08:09 | hgbot | Note Added: 0124862 | |
2020-12-16 08:09 | hgbot | Note Added: 0124863 | |
2020-12-16 08:09 | hgbot | Note Added: 0124864 | |
2020-12-16 08:10 | marvintm | Note Deleted: 0124850 | |
2020-12-16 08:10 | hgbot | Note Added: 0124865 | |
2020-12-16 08:10 | hgbot | Note Added: 0124866 | |
2020-12-16 08:10 | marvintm | Note Deleted: 0124851 | |
2020-12-16 08:11 | marvintm | Note Deleted: 0124865 | |
2020-12-16 08:11 | marvintm | Note Deleted: 0124866 | |
2020-12-16 12:12 | hgbot | Note Added: 0124880 | |
2020-12-16 12:12 | hgbot | Note Added: 0124881 | |
2020-12-16 12:12 | hgbot | Note Added: 0124882 | |
2020-12-16 12:12 | hgbot | Note Added: 0124883 | |
2020-12-17 03:32 | ranjith_qualiantech_com | File Added: 45561_20Q1_mobilecore.diff | |
2020-12-17 03:32 | ranjith_qualiantech_com | File Added: 45561_20Q1_complementary.diff | |
2020-12-17 03:33 | ranjith_qualiantech_com | File Added: 45561_20Q1_mobilewarehouse.diff | |
2020-12-17 03:34 | ranjith_qualiantech_com | File Added: 45561_20Q1_mobileprocurement.diff | |
2020-12-17 06:42 | marvintm | Relationship added | related to 0045597 |
Copyright © 2000 - 2009 MantisBT Group |