Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045561Retail ModulesWeb POSpublic2020-12-14 08:292020-12-17 03:34
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045561: Service workers infrastructure precaches CSS files that are then never used
DescriptionCurrently there is code inside the Service workers/AppCacheManifest infrastructure that adds CSS files belonging to external modules automatically to the Manifest as separate requests:

MobileCoreApplicationCacheComponent.java: method getcssFileList()
cache-manifest-ftl <#list data.cssFileList as cssFile>
${cssFile}
</#list>

This causes the Service Worker to request and store those files separately. However, the WebPOS application then never formally requests them, as their content is already present inside the main StyleSheetResources request.

Therefore, we are wasting quite a bit of bandwidth and triggering many unnecessary requests.
 
Steps To ReproduceGo to livebuilds and access the modules instance. Check in developer tools and see that many css requests exist separately, coming from the Service Worker.

Then reload the page (F5), and realise that those css files are never actually requested by the application.
Proposed SolutionDelete both the getcssFileList method inside MobileCoreApplicationCacheComponent.java and the corresponding CSS section inside cache-manifest-ftl
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0045564RR20Q4.1 closed ranjith_qualiantech_com Service workers infrastructure precaches CSS files that are then never used 
depends on backport 0045565RR20Q3.3 closed ranjith_qualiantech_com Service workers infrastructure precaches CSS files that are then never used 
related to defect 0045597 closed Retail API change: method getcssFileList() has been removed from manifest classes 
Attached Filesdiff 45561_20Q1_mobilecore.diff (3,012) 2020-12-17 03:32
https://issues.openbravo.com/file_download.php?file_id=15168&type=bug
diff 45561_20Q1_complementary.diff (2,527) 2020-12-17 03:32
https://issues.openbravo.com/file_download.php?file_id=15170&type=bug
diff 45561_20Q1_mobilewarehouse.diff (751) 2020-12-17 03:33
https://issues.openbravo.com/file_download.php?file_id=15173&type=bug
diff 45561_20Q1_mobileprocurement.diff (2,473) 2020-12-17 03:34
https://issues.openbravo.com/file_download.php?file_id=15174&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-12-14 08:29marvintmNew Issue
2020-12-14 08:29marvintmAssigned To => Retail
2020-12-14 08:29marvintmResolution time => 1609714800
2020-12-14 08:29marvintmTriggers an Emergency Pack => No
2020-12-14 11:16shuehnerStatusnew => scheduled
2020-12-14 11:16shuehnerIssue Monitored: shuehner
2020-12-15 04:54ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-12-16 06:48hgbotNote Added: 0124848
2020-12-16 06:48hgbotNote Added: 0124849
2020-12-16 06:48hgbotNote Added: 0124850
2020-12-16 06:48hgbotNote Added: 0124851
2020-12-16 08:09hgbotResolutionopen => fixed
2020-12-16 08:09hgbotStatusscheduled => closed
2020-12-16 08:09hgbotNote Added: 0124861
2020-12-16 08:09hgbotFixed in Version => RR21Q1
2020-12-16 08:09hgbotNote Added: 0124862
2020-12-16 08:09hgbotNote Added: 0124863
2020-12-16 08:09hgbotNote Added: 0124864
2020-12-16 08:10marvintmNote Deleted: 0124850
2020-12-16 08:10hgbotNote Added: 0124865
2020-12-16 08:10hgbotNote Added: 0124866
2020-12-16 08:10marvintmNote Deleted: 0124851
2020-12-16 08:11marvintmNote Deleted: 0124865
2020-12-16 08:11marvintmNote Deleted: 0124866
2020-12-16 12:12hgbotNote Added: 0124880
2020-12-16 12:12hgbotNote Added: 0124881
2020-12-16 12:12hgbotNote Added: 0124882
2020-12-16 12:12hgbotNote Added: 0124883
2020-12-17 03:32ranjith_qualiantech_comFile Added: 45561_20Q1_mobilecore.diff
2020-12-17 03:32ranjith_qualiantech_comFile Added: 45561_20Q1_complementary.diff
2020-12-17 03:33ranjith_qualiantech_comFile Added: 45561_20Q1_mobilewarehouse.diff
2020-12-17 03:34ranjith_qualiantech_comFile Added: 45561_20Q1_mobileprocurement.diff
2020-12-17 06:42marvintmRelationship addedrelated to 0045597

Notes
(0124848)
hgbot   
2020-12-16 06:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/112 [^]
(0124849)
hgbot   
2020-12-16 06:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary/-/merge_requests/6 [^]
(0124861)
hgbot   
2020-12-16 08:09   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/112 [^]
(0124862)
hgbot   
2020-12-16 08:09   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 173c9b82f1029ebcaaf442d75a83017bed2b8daa
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-15T21:45:27+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/173c9b82f1029ebcaaf442d75a83017bed2b8daa [^]

Fixed ISSUE-45561: Removed CSS Componenet in Cache Component

---
M src/org/openbravo/mobile/core/BaseCoreAppCacheResourceProvider.java
M src/org/openbravo/mobile/core/MobileCoreApplicationCacheComponent.java
M src/org/openbravo/mobile/core/templates/cache-manifest.ftl
---
(0124863)
hgbot   
2020-12-16 08:09   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary [^]
Changeset: 1eb125eabbf8c86ff4f26731c9c550f16e7f6fc6
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-15T15:29:38+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary/-/commit/1eb125eabbf8c86ff4f26731c9c550f16e7f6fc6 [^]

Related to ISSUE-45561: Removed CSS Componenet in Cache Component Provider

---
M src/org/openbravo/retail/complementary/ComplementaryAppCacheProvider.java
---
(0124864)
hgbot   
2020-12-16 08:09   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary/-/merge_requests/6 [^]
(0124880)
hgbot   
2020-12-16 12:12   
Repository: https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.mobile.warehouse [^]
Changeset: 9cb274f3aad2f4c58596a96880a229e99e5f9610
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-15T15:29:47+05:30
URL: https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.mobile.warehouse/-/commit/9cb274f3aad2f4c58596a96880a229e99e5f9610 [^]

Related to ISSUE-45561: Removed CSS Componenet in Cache Component Provider

---
M src/org/openbravo/mobile/warehouse/WarehouseApplicationCacheComponent.java
---
(0124881)
hgbot   
2020-12-16 12:12   
Merge request merged: https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.mobile.warehouse/-/merge_requests/1 [^]
(0124882)
hgbot   
2020-12-16 12:12   
Repository: https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.mobile.procurement [^]
Changeset: 665b15c75dc3503bf07ce5eff57239f43235b655
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-15T15:29:53+05:30
URL: https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.mobile.procurement/-/commit/665b15c75dc3503bf07ce5eff57239f43235b655 [^]

Related to ISSUE-45561: Removed CSS Componenet in Cache Component Provider

---
M src/org/openbravo/mobile/procurement/ProcurementApplicationCacheComponent.java
---
(0124883)
hgbot   
2020-12-16 12:12   
Merge request merged: https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.mobile.procurement/-/merge_requests/1 [^]