Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045597Retail ModulesWeb POSpublic2020-12-17 06:422020-12-17 06:45
Reportermarvintm 
Assigned ToRetail 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3.3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045597: API change: method getcssFileList() has been removed from manifest classes
DescriptionThe manifest generator classes ( and ) previously had a method called getcssFileList(). We have removed it, as it just added all CSS files blindly to the manifest, and this was useless and wrong.

The reason it was useless is that CSS files are added to the main StyleSheetComponent, and there they are properly minimised and attached in the correct order. The manifest then just loaded them separately, but the application never requested those files separately, so it was just a waste of network bandwidth without any reason.
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0045561 closed ranjith_qualiantech_com Service workers infrastructure precaches CSS files that are then never used 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-12-17 06:42marvintmNew Issue
2020-12-17 06:42marvintmAssigned To => Retail
2020-12-17 06:42marvintmTriggers an Emergency Pack => No
2020-12-17 06:42marvintmRelationship addedrelated to 0045561
2020-12-17 06:44hgbotResolutionopen => fixed
2020-12-17 06:44hgbotStatusnew => resolved
2020-12-17 06:44hgbotNote Added: 0124893
2020-12-17 06:45marvintmReview Assigned To => marvintm
2020-12-17 06:45marvintmStatusresolved => closed
2020-12-17 06:45marvintmFixed in Version => RR21Q1
2020-12-17 06:45marvintmFixed in VersionRR21Q1 => RR20Q3.3

Notes
(0124893)
hgbot   
2020-12-17 06:44   
Repository: https://gitlab.com/openbravo/ci/mobile-api [^]
Changeset: c6821711d5301a33f81d7c422c57f83333282702
Author: Antonio Moreno <anmorenoperez@gmail.com>
Date: 2020-12-17T06:44:20+01:00
URL: https://gitlab.com/openbravo/ci/mobile-api/-/commit/c6821711d5301a33f81d7c422c57f83333282702 [^]

Fixed ISSUE-45597: Method getcssFileList has been removed from manifest generating classes.
This method just blindly added all CSS files to the manifest. This meant that they were then precached automatically by the service workers cache. However, this was never needed, as the CSS files are actually included inside the separate StyleSheetResourceComponent request, and therefore we were basically loading them twice.

---
M java/reference/java.japi.gz
---