Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0045433
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajorhave not tried2020-11-11 09:202020-11-12 14:22
ReporterAugustoMauchView Statuspublic 
Assigned ToRetail 
PriorityimmediateResolutionfixedFixed in VersionRR20Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionRR20Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression levelProduction - QA Approved
Regression date2020-05-19
Regression introduced in releaseRR20Q3
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7caf16c2e1e608f8fa1fdc7a60e564b6c8a06414 [^]
Triggers an Emergency PackNo
Summary

0045433: Error when clicking on Manage Addresses button on customer detail popup when using remote customers

DescriptionIn an environment where customers are configured to be remote, clicking on the Manage Addresses button on the customer detail results in an error, and the popup to manage addresses is not opened.

Uncaught TypeError: Cannot read property 'doShowPopup' of undefined
    at sucessCallBack (3e5922328757d03f3b29a0b11e4d3f77.js:121286)
    at 3e5922328757d03f3b29a0b11e4d3f77.js:121309
    at 3e5922328757d03f3b29a0b11e4d3f77.js:9059
    at serviceSuccess (3e5922328757d03f3b29a0b11e4d3f77.js:2110)
    at Object.success [as origSuccess] (3e5922328757d03f3b29a0b11e4d3f77.js:2255)
    at callback (3e5922328757d03f3b29a0b11e4d3f77.js:3754)
    at Object.ajaxRequest.success (3e5922328757d03f3b29a0b11e4d3f77.js:3820)
    at Object.newAjaxRequest.execAjaxSuccess (3e5922328757d03f3b29a0b11e4d3f77.js:5376)
    at Object.enyo.call (enyo.js:335)
    at Object.handle (enyo.js:889)

The error seems to be in this line:

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js#L200 [^]

The callback of OB.Dal.get should be a function that accepts one input parameter. In this case "me" is included as second parameter and is never being assigned, and then passed to the sucessCallBack undefined.
Steps To Reproduce- Configure customers to be remote
- Open WebPOS
- Assign a customer to the ticket
- Show the details of the customer
- Click on the manage addresses button,an error will be shown
Proposed Solutiondiff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js b/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
index 21e4f73fa..f969b21b0 100644
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
@@ -197,7 +197,7 @@ enyo.kind({
       OB.Dal.get(
         OB.Model.BusinessPartner,
         me.parent.customer.get('id'),
- function(bp, me) {
+ function(bp) {
           sucessCallBack(bp, me);
         }
       );
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0045416 closedranjith_qualiantech_com Error when clicking on Manage Addresses button on customer detail popup when using remote customers 

-  Notes
(0124326)
hgbot (developer)
2020-11-12 14:22

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 06bed3343f345d44f9c8848f9e6e2bbafca8a523
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-11-12T18:52:35+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/06bed3343f345d44f9c8848f9e6e2bbafca8a523 [^]

Fixed ISSUE-45433: Removed unwanted param in ManageAddress Button in Customer details popup

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
---

- Issue History
Date Modified Username Field Change
2020-11-12 12:55 marvintm Type defect => backport
2020-11-12 12:55 marvintm Target Version => RR20Q4
2020-11-12 14:22 hgbot Resolution open => fixed
2020-11-12 14:22 hgbot Status scheduled => closed
2020-11-12 14:22 hgbot Fixed in Version => RR20Q4
2020-11-12 14:22 hgbot Note Added: 0124326


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker