Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045416
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2020-11-11 09:202020-11-12 12:55
ReporterAugustoMauchView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityimmediateResolutionfixedFixed in VersionRR21Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression levelProduction - QA Approved
Regression date2020-05-19
Regression introduced in releaseRR20Q3
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7caf16c2e1e608f8fa1fdc7a60e564b6c8a06414 [^]
Triggers an Emergency PackNo
Summary

0045416: Error when clicking on Manage Addresses button on customer detail popup when using remote customers

DescriptionIn an environment where customers are configured to be remote, clicking on the Manage Addresses button on the customer detail results in an error, and the popup to manage addresses is not opened.

Uncaught TypeError: Cannot read property 'doShowPopup' of undefined
    at sucessCallBack (3e5922328757d03f3b29a0b11e4d3f77.js:121286)
    at 3e5922328757d03f3b29a0b11e4d3f77.js:121309
    at 3e5922328757d03f3b29a0b11e4d3f77.js:9059
    at serviceSuccess (3e5922328757d03f3b29a0b11e4d3f77.js:2110)
    at Object.success [as origSuccess] (3e5922328757d03f3b29a0b11e4d3f77.js:2255)
    at callback (3e5922328757d03f3b29a0b11e4d3f77.js:3754)
    at Object.ajaxRequest.success (3e5922328757d03f3b29a0b11e4d3f77.js:3820)
    at Object.newAjaxRequest.execAjaxSuccess (3e5922328757d03f3b29a0b11e4d3f77.js:5376)
    at Object.enyo.call (enyo.js:335)
    at Object.handle (enyo.js:889)

The error seems to be in this line:

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js#L200 [^]

The callback of OB.Dal.get should be a function that accepts one input parameter. In this case "me" is included as second parameter and is never being assigned, and then passed to the sucessCallBack undefined.
Steps To Reproduce- Configure customers to be remote
- Open WebPOS
- Assign a customer to the ticket
- Show the details of the customer
- Click on the manage addresses button,an error will be shown
Proposed Solutiondiff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js b/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
index 21e4f73fa..f969b21b0 100644
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
@@ -197,7 +197,7 @@ enyo.kind({
       OB.Dal.get(
         OB.Model.BusinessPartner,
         me.parent.customer.get('id'),
- function(bp, me) {
+ function(bp) {
           sucessCallBack(bp, me);
         }
       );
TagsNOR
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0045433RR20Q4 closedRetail Error when clicking on Manage Addresses button on customer detail popup when using remote customers 
depends on backport 0045434RR20Q3.2 closedRetail Error when clicking on Manage Addresses button on customer detail popup when using remote customers 

-  Notes
(0124294)
hgbot (developer)
2020-11-12 08:34

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/169 [^]
(0124322)
hgbot (developer)
2020-11-12 12:55

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 322a6ea4621b3c523584f29cb3975475396bc28a
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-11-12T11:54:59+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/322a6ea4621b3c523584f29cb3975475396bc28a [^]

Fixed ISSUE-45416: Removed unwanted param in ManageAddress Button in Customer details popup

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
---
(0124323)
hgbot (developer)
2020-11-12 12:55

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/169 [^]

- Issue History
Date Modified Username Field Change
2020-11-11 09:20 AugustoMauch New Issue
2020-11-11 09:20 AugustoMauch Assigned To => Retail
2020-11-11 09:20 AugustoMauch OBNetwork customer => No
2020-11-11 09:20 AugustoMauch Triggers an Emergency Pack => No
2020-11-11 09:22 AugustoMauch Regression level => Production - QA Approved
2020-11-11 09:22 AugustoMauch Regression date => 2020-05-19
2020-11-11 09:22 AugustoMauch Regression introduced in release => RR20Q3
2020-11-11 09:22 AugustoMauch Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7caf16c2e1e608f8fa1fdc7a60e564b6c8a06414 [^]
2020-11-11 11:04 rafaroda Tag Attached: NOR
2020-11-12 08:34 hgbot Merge Request Status => open
2020-11-12 08:34 hgbot Note Added: 0124294
2020-11-12 12:54 hgbot Merge Request Status open => approved
2020-11-12 12:55 hgbot Resolution open => fixed
2020-11-12 12:55 hgbot Status new => closed
2020-11-12 12:55 hgbot Fixed in Version => RR21Q1
2020-11-12 12:55 hgbot Note Added: 0124322
2020-11-12 12:55 hgbot Note Added: 0124323
2020-11-12 12:55 marvintm Status closed => new
2020-11-12 12:55 marvintm Resolution fixed => open
2020-11-12 12:55 marvintm Fixed in Version RR21Q1 =>
2020-11-12 12:55 marvintm Status new => scheduled
2020-11-12 12:55 marvintm Status scheduled => resolved
2020-11-12 12:55 marvintm Fixed in Version => RR21Q1
2020-11-12 12:55 marvintm Resolution open => fixed
2020-11-12 12:55 marvintm Review Assigned To => marvintm
2020-11-12 12:55 marvintm Status resolved => closed
2020-11-12 12:55 marvintm Assigned To Retail => ranjith_qualiantech_com

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker