0045434: Error when clicking on Manage Addresses button on customer detail popup when using remote customers

Description

In an environment where customers are configured to be remote, clicking on the Manage Addresses button on the customer detail results in an error, and the popup to manage addresses is not opened.

Uncaught TypeError: Cannot read property 'doShowPopup' of undefined
    at sucessCallBack (3e5922328757d03f3b29a0b11e4d3f77.js:121286)
    at 3e5922328757d03f3b29a0b11e4d3f77.js:121309
    at 3e5922328757d03f3b29a0b11e4d3f77.js:9059
    at serviceSuccess (3e5922328757d03f3b29a0b11e4d3f77.js:2110)
    at Object.success [as origSuccess] (3e5922328757d03f3b29a0b11e4d3f77.js:2255)
    at callback (3e5922328757d03f3b29a0b11e4d3f77.js:3754)
    at Object.ajaxRequest.success (3e5922328757d03f3b29a0b11e4d3f77.js:3820)
    at Object.newAjaxRequest.execAjaxSuccess (3e5922328757d03f3b29a0b11e4d3f77.js:5376)
    at Object.enyo.call (enyo.js:335)
    at Object.handle (enyo.js:889)

The error seems to be in this line:

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js#L200 [^]

The callback of OB.Dal.get should be a function that accepts one input parameter. In this case "me" is included as second parameter and is never being assigned, and then passed to the sucessCallBack undefined.

Steps To Reproduce

- Configure customers to be remote
- Open WebPOS
- Assign a customer to the ticket
- Show the details of the customer
- Click on the manage addresses button,an error will be shown

Proposed Solution

diff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js b/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
index 21e4f73fa..f969b21b0 100644
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
@@ -197,7 +197,7 @@ enyo.kind({
       OB.Dal.get(
         OB.Model.BusinessPartner,
         me.parent.customer.get('id'),
- function(bp, me) {
+ function(bp) {
           sucessCallBack(bp, me);
         }
       );

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0045416

closed

ranjith_qualiantech_com

Error when clicking on Manage Addresses button on customer detail popup when using remote customers

Notes
(0124325) hgbot (developer) 2020-11-12 14:21	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 67c00c4bc7d1a8bcd29d9a9999b2bf32f0731f6d Author: Ranjith S R <ranjith@qualiantech.com> Date: 2020-11-12T18:50:50+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/67c00c4bc7d1a8bcd29d9a9999b2bf32f0731f6d [^] Fixed ISSUE-45434: Removed unwanted param in ManageAddress Button in Customer details popup --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js ---

Issue History
Date Modified	Username	Field	Change
2020-11-12 12:55	marvintm	Type	defect => backport
2020-11-12 12:55	marvintm	Target Version	=> RR20Q3.2
2020-11-12 14:21	hgbot	Resolution	open => fixed
2020-11-12 14:21	hgbot	Status	scheduled => closed
2020-11-12 14:21	hgbot	Fixed in Version	=> RR20Q3.2
2020-11-12 14:21	hgbot	Note Added: 0124325