0045433: Error when clicking on Manage Addresses button on customer detail popup when using remote customers

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0045433

Retail Modules

Web POS

public

2020-11-11 09:20

2020-11-12 14:22

Reporter

AugustoMauch

Assigned To

Retail

Priority

immediate

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR20Q4

Fixed in Version

RR20Q4

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Production - QA Approved

Regression date

2020-05-19

Regression introduced in release

RR20Q3

Regression introduced by commit

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7caf16c2e1e608f8fa1fdc7a60e564b6c8a06414 [^]

Triggers an Emergency Pack

Summary

0045433: Error when clicking on Manage Addresses button on customer detail popup when using remote customers

Description

In an environment where customers are configured to be remote, clicking on the Manage Addresses button on the customer detail results in an error, and the popup to manage addresses is not opened.

Uncaught TypeError: Cannot read property 'doShowPopup' of undefined
    at sucessCallBack (3e5922328757d03f3b29a0b11e4d3f77.js:121286)
    at 3e5922328757d03f3b29a0b11e4d3f77.js:121309
    at 3e5922328757d03f3b29a0b11e4d3f77.js:9059
    at serviceSuccess (3e5922328757d03f3b29a0b11e4d3f77.js:2110)
    at Object.success [as origSuccess] (3e5922328757d03f3b29a0b11e4d3f77.js:2255)
    at callback (3e5922328757d03f3b29a0b11e4d3f77.js:3754)
    at Object.ajaxRequest.success (3e5922328757d03f3b29a0b11e4d3f77.js:3820)
    at Object.newAjaxRequest.execAjaxSuccess (3e5922328757d03f3b29a0b11e4d3f77.js:5376)
    at Object.enyo.call (enyo.js:335)
    at Object.handle (enyo.js:889)

The error seems to be in this line:

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js#L200 [^]

The callback of OB.Dal.get should be a function that accepts one input parameter. In this case "me" is included as second parameter and is never being assigned, and then passed to the sucessCallBack undefined.

Steps To Reproduce

- Configure customers to be remote
- Open WebPOS
- Assign a customer to the ticket
- Show the details of the customer
- Click on the manage addresses button,an error will be shown

Proposed Solution

diff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js b/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
index 21e4f73fa..f969b21b0 100644
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
@@ -197,7 +197,7 @@ enyo.kind({
       OB.Dal.get(
         OB.Model.BusinessPartner,
         me.parent.customer.get('id'),
- function(bp, me) {
+ function(bp) {
           sucessCallBack(bp, me);
         }
       );

Additional Information