Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0045188 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | major | always | 2020-10-05 11:40 | 2021-01-28 13:20 | |||
Reporter | rafaroda | View Status | public | |||||
Assigned To | ranjith_qualiantech_com | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | RR21Q1 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0045188: Incremental Refresh fail: continues the load when it should stop | |||||||
Description | Incremental Refresh fail: continues the load when it should stop | |||||||
Steps To Reproduce | Have a failed Incremental refresh: because of timeout for instance Incremental refresh continues with the load of the rest of models, that could lead to inconsistent states: * For instance, if Product model failed * Product Characteristics Values could be orphan Or it can be confusing for the user that does not understand when a Promo is missing, see 0044662 | |||||||
Proposed Solution | Stop the Incremental refresh load if something fails? Or other solution: for sure this is confusing for the user since unless it checks the Chrome Console he won't know that something did not load | |||||||
Tags | NOR | |||||||
Attached Files | 45188_20Q3._mobilecore.diff [^] (1,865 bytes) 2021-01-28 13:20 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Notes | |
(0123528) rafaroda (developer) 2020-10-05 12:06 |
See related 0045187 |
(0123669) hgbot (developer) 2020-10-14 07:54 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/82 [^] |
(0124018) hgbot (developer) 2020-10-29 16:06 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: b1913ba35d19c69af2a18dc785ccefdf18e04133 Author: Ranjith S R <ranjith@qualiantech.com> Date: 2020-10-29T15:06:31+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/b1913ba35d19c69af2a18dc785ccefdf18e04133 [^] Fixed ISSUE-45188: Prevent Subsequent request when MasterData request fails * For Incremental & Full refresh, Masterdata for models should be updated only when all masterdata request are success --- M web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js --- |
(0124019) hgbot (developer) 2020-10-29 16:06 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/82 [^] |
(0124021) marvintm (manager) 2020-10-29 16:10 |
Just to clarify: the change done ensures that once a request has failed, subsequent requests will not be triggered. In case of full refresh, the user will be then prompted to restart the refresh again, as database is recreated every time full refresh is done, so all subsequent entities will be missing. In case of incremental refresh, the WebPOS automatically navigates to the main window in offline mode after previous models have been updated. It is indeed possible that inconsistencies in masterdata may happen. However, it is not possible for us to prevent this (as data needs to be downloaded in chunks, and cannot be inserted or updated "transactionally" due to the fact that neither IndexedDB provides an API capable of doing this while Ajax requests are done, nor we have enough memory to keep all loaded data before actually inserting it). |
Issue History | |||
Date Modified | Username | Field | Change |
2020-10-05 11:40 | rafaroda | New Issue | |
2020-10-05 11:40 | rafaroda | Assigned To | => Retail |
2020-10-05 11:40 | rafaroda | Resolution time | => 1603144800 |
2020-10-05 11:40 | rafaroda | Triggers an Emergency Pack | => No |
2020-10-05 11:40 | rafaroda | Issue generated from | 0045187 |
2020-10-05 11:40 | rafaroda | Relationship added | related to 0045187 |
2020-10-05 11:40 | rafaroda | Tag Attached: NOR | |
2020-10-05 11:41 | rafaroda | Relationship added | related to 0044662 |
2020-10-05 11:41 | rafaroda | Relationship added | related to 0045155 |
2020-10-05 11:41 | rafaroda | Relationship added | related to 0045154 |
2020-10-05 11:42 | rafaroda | Relationship added | related to 0045153 |
2020-10-05 12:06 | rafaroda | Note Added: 0123528 | |
2020-10-09 11:50 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
2020-10-09 11:50 | ranjith_qualiantech_com | Status | new => scheduled |
2020-10-14 07:54 | hgbot | Note Added: 0123669 | |
2020-10-29 16:06 | hgbot | Resolution | open => fixed |
2020-10-29 16:06 | hgbot | Status | scheduled => closed |
2020-10-29 16:06 | hgbot | Fixed in Version | => RR21Q1 |
2020-10-29 16:06 | hgbot | Note Added: 0124018 | |
2020-10-29 16:06 | hgbot | Note Added: 0124019 | |
2020-10-29 16:10 | marvintm | Note Added: 0124021 | |
2021-01-28 13:20 | ranjith_qualiantech_com | File Added: 45188_20Q3._mobilecore.diff | |
2021-02-02 13:01 | rafaroda | Relationship added | related to 0045834 |
2021-02-03 16:56 | rafaroda | Relationship added | related to 0045842 |
2021-02-04 12:49 | rafaroda | Relationship added | blocks 0045852 |
2021-02-04 12:49 | rafaroda | Relationship deleted | blocks 0045852 |
2021-02-04 12:50 | rafaroda | Relationship added | related to 0045852 |
2021-02-10 14:47 | rafaroda | Relationship added | related to 0045879 |
Copyright © 2000 - 2009 MantisBT Group |