Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045188Retail ModulesWeb POSpublic2020-10-05 11:402021-01-28 13:20
Reporterrafaroda 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045188: Incremental Refresh fail: continues the load when it should stop
DescriptionIncremental Refresh fail: continues the load when it should stop
Steps To ReproduceHave a failed Incremental refresh: because of timeout for instance

Incremental refresh continues with the load of the rest of models, that could lead to inconsistent states:
* For instance, if Product model failed
* Product Characteristics Values could be orphan

Or it can be confusing for the user that does not understand when a Promo is missing, see 0044662
Proposed SolutionStop the Incremental refresh load if something fails? Or other solution: for sure this is confusing for the user since unless it checks the Chrome Console he won't know that something did not load
Additional Information
TagsNOR
Relationships
related to defect 0045187 closed ranjith_qualiantech_com Full Refresh fail: continues the load when it should stop 
related to defect 0044662 closed ranjith_qualiantech_com Discounts are not updated on webpos after incremental refresh 
related to defect 0045155 closed Retail Discount and promotion- Removing filters are not sent to WebPOS 
related to defect 0045154 closed ranjith_qualiantech_com Discount and promotion - Filter change are not sent to WebPOS 
related to defect 0045153 closed ranjith_qualiantech_com Discount and promotion - Disabling organizations are not sent to WebPOS 
related to defect 0045834 closed ranjith_qualiantech_com When an incremental refresh fails, the field 'Channel - Touchpoint || Incremental Refresh Masterdata Load' is updated 
related to defect 0045842 closed ranjith_qualiantech_com Confused message when the Full Refresh fails 
related to defect 0045852 closed ranjith_qualiantech_com Wrong behaviour when the browser is closed before Full Refresh finishes 
related to defect 0045879 closed ranjith_qualiantech_com Full refresh does not restar after F5 in all the cases 
Attached Filesdiff 45188_20Q3._mobilecore.diff (1,865) 2021-01-28 13:20
https://issues.openbravo.com/file_download.php?file_id=15285&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-10-05 11:40rafarodaNew Issue
2020-10-05 11:40rafarodaAssigned To => Retail
2020-10-05 11:40rafarodaResolution time => 1603144800
2020-10-05 11:40rafarodaTriggers an Emergency Pack => No
2020-10-05 11:40rafarodaIssue generated from0045187
2020-10-05 11:40rafarodaRelationship addedrelated to 0045187
2020-10-05 11:40rafarodaTag Attached: NOR
2020-10-05 11:41rafarodaRelationship addedrelated to 0044662
2020-10-05 11:41rafarodaRelationship addedrelated to 0045155
2020-10-05 11:41rafarodaRelationship addedrelated to 0045154
2020-10-05 11:42rafarodaRelationship addedrelated to 0045153
2020-10-05 12:06rafarodaNote Added: 0123528
2020-10-09 11:50ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-10-09 11:50ranjith_qualiantech_comStatusnew => scheduled
2020-10-14 07:54hgbotNote Added: 0123669
2020-10-29 16:06hgbotResolutionopen => fixed
2020-10-29 16:06hgbotStatusscheduled => closed
2020-10-29 16:06hgbotFixed in Version => RR21Q1
2020-10-29 16:06hgbotNote Added: 0124018
2020-10-29 16:06hgbotNote Added: 0124019
2020-10-29 16:10marvintmNote Added: 0124021
2021-01-28 13:20ranjith_qualiantech_comFile Added: 45188_20Q3._mobilecore.diff
2021-02-02 13:01rafarodaRelationship addedrelated to 0045834
2021-02-03 16:56rafarodaRelationship addedrelated to 0045842
2021-02-04 12:49rafarodaRelationship addedblocks 0045852
2021-02-04 12:49rafarodaRelationship deletedblocks 0045852
2021-02-04 12:50rafarodaRelationship addedrelated to 0045852
2021-02-10 14:47rafarodaRelationship addedrelated to 0045879

Notes
(0123528)
rafaroda   
2020-10-05 12:06   
See related 0045187
(0123669)
hgbot   
2020-10-14 07:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/82 [^]
(0124018)
hgbot   
2020-10-29 16:06   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: b1913ba35d19c69af2a18dc785ccefdf18e04133
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-10-29T15:06:31+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/b1913ba35d19c69af2a18dc785ccefdf18e04133 [^]

Fixed ISSUE-45188: Prevent Subsequent request when MasterData request fails
* For Incremental & Full refresh, Masterdata for models should be updated only when all masterdata request are success

---
M web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js
---
(0124019)
hgbot   
2020-10-29 16:06   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/82 [^]
(0124021)
marvintm   
2020-10-29 16:10   
Just to clarify: the change done ensures that once a request has failed, subsequent requests will not be triggered.

In case of full refresh, the user will be then prompted to restart the refresh again, as database is recreated every time full refresh is done, so all subsequent entities will be missing.

In case of incremental refresh, the WebPOS automatically navigates to the main window in offline mode after previous models have been updated.

It is indeed possible that inconsistencies in masterdata may happen. However, it is not possible for us to prevent this (as data needs to be downloaded in chunks, and cannot be inserted or updated "transactionally" due to the fact that neither IndexedDB provides an API capable of doing this while Ajax requests are done, nor we have enough memory to keep all loaded data before actually inserting it).