Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0044297
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2020-06-05 14:112020-06-17 08:35
ReportergorkaionView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR20Q3
StatusclosedFix in branchFixed in SCM revisionda87fdd6684b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0044297: EOL does not generate shipment lines automatically with step all.

DescriptionWhen step all is set on the EOL json the generateShipment flag is automatically set among others. It is also setting the deliver qty on all the lines based on the step.

This therefor tries to create the shipment for the order. But the shipment utils class is checking the isObposIsPaid flag status for each order line [1] which is set as false by default so no shipment line is created.

This can be a potential regression introduced in commit [2] by prepayments implementation. In previous releases it is not required to include any extra flag on the EOL json to generate the shipment.


[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/2a99f2895071f95d0e189c0fc31a821aedc1b659/src/org/openbravo/retail/posterminal/utility/ShipmentUtils.java#l207 [^]
[2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a8ecf7965ff7 [^]
Steps To ReproduceProcess a EOL with step ALL.
Note that no shipment is generated.
Proposed SolutionThe EOL should also set the isobpospaid flag to true when the shipment is required to be generated.
TagsNo tags attached.
Attached Filespatch file icon issue 44297 source posterminal.patch [^] (2,645 bytes) 2020-06-10 14:51 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0044375RR20Q2.1 closedranjith_qualiantech_com EOL does not generate shipment lines automatically with step all. 
depends on backport 0044376RR20Q1.3 closedranjith_qualiantech_com EOL does not generate shipment lines automatically with step all. 

-  Notes
(0120879)
hgbot (developer)
2020-06-17 08:33

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: da87fdd6684bbb59ef624705732a3d46b88b666d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jun 17 12:03:11 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/da87fdd6684bbb59ef624705732a3d46b88b666d [^]

Fixed issue-44297 : OrderLine isPaid should be updated in ExternalOrderLoader

* In ExternalOrderLoader, if order is fully paid or paid on Credit, then
  lines isPaid should be updated as true

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---

- Issue History
Date Modified Username Field Change
2020-06-05 14:11 gorkaion New Issue
2020-06-05 14:11 gorkaion Assigned To => Retail
2020-06-05 14:11 gorkaion Resolution time => 1593122400
2020-06-05 14:11 gorkaion Triggers an Emergency Pack => No
2020-06-10 08:23 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2020-06-10 14:51 ranjith_qualiantech_com File Added: issue 44297 source posterminal.patch
2020-06-16 16:28 ranjith_qualiantech_com Status new => scheduled
2020-06-17 08:33 hgbot Checkin
2020-06-17 08:33 hgbot Note Added: 0120879
2020-06-17 08:33 hgbot Status scheduled => resolved
2020-06-17 08:33 hgbot Resolution open => fixed
2020-06-17 08:33 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/da87fdd6684bbb59ef624705732a3d46b88b666d [^]
2020-06-17 08:35 marvintm Review Assigned To => marvintm
2020-06-17 08:35 marvintm Status resolved => closed
2020-06-17 08:35 marvintm Fixed in Version => RR20Q3


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker