Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044376
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajorhave not tried2020-06-05 14:112020-07-09 14:31
ReportergorkaionView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR20Q1.3
StatusclosedFix in branchFixed in SCM revisionb88707d3691e
ProjectionnoneETAnoneTarget VersionRR20Q1.3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket16214
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0044376: EOL does not generate shipment lines automatically with step all.

DescriptionWhen step all is set on the EOL json the generateShipment flag is automatically set among others. It is also setting the deliver qty on all the lines based on the step.

This therefor tries to create the shipment for the order. But the shipment utils class is checking the isObposIsPaid flag status for each order line [1] which is set as false by default so no shipment line is created.

This can be a potential regression introduced in commit [2] by prepayments implementation. In previous releases it is not required to include any extra flag on the EOL json to generate the shipment.


[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/2a99f2895071f95d0e189c0fc31a821aedc1b659/src/org/openbravo/retail/posterminal/utility/ShipmentUtils.java#l207 [^]
[2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a8ecf7965ff7 [^]
Steps To ReproduceProcess a EOL with step ALL.
Note that no shipment is generated.
Proposed SolutionThe EOL should also set the isobpospaid flag to true when the shipment is required to be generated.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0044297 closedranjith_qualiantech_com EOL does not generate shipment lines automatically with step all. 

-  Notes
(0120917)
hgbot (developer)
2020-06-19 09:46

 Repository: retail/backports/3.0RR20Q1.3/org.openbravo.retail.posterminal
Changeset: b88707d3691e5c0e9170e57f0f2e2ba420ae80b3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jun 17 12:03:11 2020 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR20Q1.3/org.openbravo.retail.posterminal/rev/b88707d3691e5c0e9170e57f0f2e2ba420ae80b3 [^]

Fixed issue-44376 : OrderLine isPaid should be updated in ExternalOrderLoader

* In ExternalOrderLoader, if order is fully paid or paid on Credit, then
  lines isPaid should be updated as true

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0121357)
hgbot (developer)
2020-07-09 14:13

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 287d4cee266a565f52a29dddf440dfe351da7c3f
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-07-09T12:13:06+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/287d4cee266a565f52a29dddf440dfe351da7c3f [^]

Fixed issue-44376 : OrderLine isPaid should be updated in ExternalOrderLoader

* In ExternalOrderLoader, if order is fully paid or paid on Credit, then
  lines isPaid should be updated as true

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0121364)
shuehner (administrator)
2020-07-09 14:31

 Re-closing: Issues was just changed to resolved as side-effect of converting backport repos to gitlab release branch

- Issue History
Date Modified Username Field Change
2020-06-16 16:28 ranjith_qualiantech_com Type defect => backport
2020-06-16 16:28 ranjith_qualiantech_com Target Version => RR20Q1.3
2020-06-19 09:46 hgbot Checkin
2020-06-19 09:46 hgbot Note Added: 0120917
2020-06-19 09:46 hgbot Status scheduled => resolved
2020-06-19 09:46 hgbot Resolution open => fixed
2020-06-19 09:46 hgbot Fixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR20Q1.3/org.openbravo.retail.posterminal/rev/b88707d3691e5c0e9170e57f0f2e2ba420ae80b3 [^]
2020-06-29 12:39 marvintm Review Assigned To => marvintm
2020-06-29 12:39 marvintm Status resolved => closed
2020-06-29 12:39 marvintm Fixed in Version => RR20Q1.3
2020-07-09 14:13 hgbot Status closed => resolved
2020-07-09 14:13 hgbot Note Added: 0121357
2020-07-09 14:31 shuehner Note Added: 0121364
2020-07-09 14:31 shuehner Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker