Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044297Retail ModulesWeb POSpublic2020-06-05 14:112020-06-17 08:35
Reportergorkaion 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044297: EOL does not generate shipment lines automatically with step all.
DescriptionWhen step all is set on the EOL json the generateShipment flag is automatically set among others. It is also setting the deliver qty on all the lines based on the step.

This therefor tries to create the shipment for the order. But the shipment utils class is checking the isObposIsPaid flag status for each order line [1] which is set as false by default so no shipment line is created.

This can be a potential regression introduced in commit [2] by prepayments implementation. In previous releases it is not required to include any extra flag on the EOL json to generate the shipment.


[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/2a99f2895071f95d0e189c0fc31a821aedc1b659/src/org/openbravo/retail/posterminal/utility/ShipmentUtils.java#l207 [^]
[2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a8ecf7965ff7 [^]
Steps To ReproduceProcess a EOL with step ALL.
Note that no shipment is generated.
Proposed SolutionThe EOL should also set the isobpospaid flag to true when the shipment is required to be generated.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0044375RR20Q2.1 closed ranjith_qualiantech_com EOL does not generate shipment lines automatically with step all. 
depends on backport 0044376RR20Q1.3 closed ranjith_qualiantech_com EOL does not generate shipment lines automatically with step all. 
Attached Filespatch issue 44297 source posterminal.patch (2,645) 2020-06-10 14:51
https://issues.openbravo.com/file_download.php?file_id=14609&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-06-05 14:11gorkaionNew Issue
2020-06-05 14:11gorkaionAssigned To => Retail
2020-06-05 14:11gorkaionResolution time => 1593122400
2020-06-05 14:11gorkaionTriggers an Emergency Pack => No
2020-06-10 08:23ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-06-10 14:51ranjith_qualiantech_comFile Added: issue 44297 source posterminal.patch
2020-06-16 16:28ranjith_qualiantech_comStatusnew => scheduled
2020-06-17 08:33hgbotCheckin
2020-06-17 08:33hgbotNote Added: 0120879
2020-06-17 08:33hgbotStatusscheduled => resolved
2020-06-17 08:33hgbotResolutionopen => fixed
2020-06-17 08:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/da87fdd6684bbb59ef624705732a3d46b88b666d [^]
2020-06-17 08:35marvintmReview Assigned To => marvintm
2020-06-17 08:35marvintmStatusresolved => closed
2020-06-17 08:35marvintmFixed in Version => RR20Q3

Notes
(0120879)
hgbot   
2020-06-17 08:33   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: da87fdd6684bbb59ef624705732a3d46b88b666d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jun 17 12:03:11 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/da87fdd6684bbb59ef624705732a3d46b88b666d [^]

Fixed issue-44297 : OrderLine isPaid should be updated in ExternalOrderLoader

* In ExternalOrderLoader, if order is fully paid or paid on Credit, then
  lines isPaid should be updated as true

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---