0043822: VoidLayaway.java can throw NPE

Description

VoidLayaway.java is retrieving values from jsonorder without a sannity check. This value is sent as null from autocancelreservation for example.

Steps To Reproduce

Install autocancelreservation
Create a layaway
Run the auto void layaway process
Check that the voiding process is failing due to the NPE

Proposed Solution

Attached patch

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

closed

VoidLayaway.java can throw NPE

Notes
(0119335) hgbot (developer) 2020-04-22 13:05	Repository: retail/backports/3.0RR19Q4.4/org.openbravo.retail.posterminal Changeset: a8b216d6c6e45518e9659e03613e9d562032068e Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Wed Apr 22 16:19:57 2020 +0530 URL: http://code.openbravo.com/retail/backports/3.0RR19Q4.4/org.openbravo.retail.posterminal/rev/a8b216d6c6e45518e9659e03613e9d562032068e [^] Fixed issue 43822: VoidLayaway.java can throw NPE - Avoided null pointer exception with autocancelreservation installed --- M src/org/openbravo/retail/posterminal/VoidLayaway.java ---

Issue History
Date Modified	Username	Field	Change
2020-04-22 11:23	marvintm	Type	defect => backport
2020-04-22 11:23	marvintm	Target Version	=> RR19Q4.4
2020-04-22 13:05	hgbot	Checkin
2020-04-22 13:05	hgbot	Note Added: 0119335
2020-04-22 13:05	hgbot	Status	scheduled => resolved
2020-04-22 13:05	hgbot	Resolution	open => fixed
2020-04-22 13:05	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9252cf8edbf5ee84c66917d7a45fab39db8e8bd1 [^] => http://code.openbravo.com/retail/backports/3.0RR19Q4.4/org.openbravo.retail.posterminal/rev/a8b216d6c6e45518e9659e03613e9d562032068e [^]
2020-04-23 17:20	marvintm	Review Assigned To	jorge-garcia => marvintm
2020-04-23 17:20	marvintm	Status	resolved => closed
2020-04-23 17:20	marvintm	Fixed in Version	=> RR19Q4.4