Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043822Retail ModulesLayaway orderpublic2019-09-19 10:382020-04-23 17:20
Reporterairaceburu 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR19Q4.4Fixed in VersionRR19Q4.4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2019-05-29
Regression introduced in releaseRR19Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1df20ca903a7#l1.8 [^]
Triggers an Emergency PackNo
Summary0043822: VoidLayaway.java can throw NPE
DescriptionVoidLayaway.java is retrieving values from jsonorder without a sannity check. This value is sent as null from autocancelreservation for example.
Steps To ReproduceInstall autocancelreservation
Create a layaway
Run the auto void layaway process
Check that the voiding process is failing due to the NPE
Proposed SolutionAttached patch
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0041852 closed rqueralta VoidLayaway.java can throw NPE 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-04-22 11:23marvintmTypedefect => backport
2020-04-22 11:23marvintmTarget Version => RR19Q4.4
2020-04-22 13:05hgbotCheckin
2020-04-22 13:05hgbotNote Added: 0119335
2020-04-22 13:05hgbotStatusscheduled => resolved
2020-04-22 13:05hgbotResolutionopen => fixed
2020-04-22 13:05hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9252cf8edbf5ee84c66917d7a45fab39db8e8bd1 [^] => http://code.openbravo.com/retail/backports/3.0RR19Q4.4/org.openbravo.retail.posterminal/rev/a8b216d6c6e45518e9659e03613e9d562032068e [^]
2020-04-23 17:20marvintmReview Assigned Tojorge-garcia => marvintm
2020-04-23 17:20marvintmStatusresolved => closed
2020-04-23 17:20marvintmFixed in Version => RR19Q4.4

Notes
(0119335)
hgbot   
2020-04-22 13:05   
Repository: retail/backports/3.0RR19Q4.4/org.openbravo.retail.posterminal
Changeset: a8b216d6c6e45518e9659e03613e9d562032068e
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Apr 22 16:19:57 2020 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR19Q4.4/org.openbravo.retail.posterminal/rev/a8b216d6c6e45518e9659e03613e9d562032068e [^]

Fixed issue 43822: VoidLayaway.java can throw NPE

- Avoided null pointer exception with autocancelreservation installed

---
M src/org/openbravo/retail/posterminal/VoidLayaway.java
---