Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041852
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Layaway ordermajoralways2019-09-19 10:382020-04-22 11:24
ReporterairaceburuView Statuspublic 
Assigned Torqueralta 
PrioritynormalResolutionfixedFixed in VersionRR20Q1
StatusclosedFix in branchFixed in SCM revision9252cf8edbf5
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tojorge-garcia
Regression levelProduction - Confirmed Stable
Regression date2019-05-29
Regression introduced in releaseRR19Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1df20ca903a7#l1.8 [^]
Triggers an Emergency PackNo
Summary

0041852: VoidLayaway.java can throw NPE

DescriptionVoidLayaway.java is retrieving values from jsonorder without a sannity check. This value is sent as null from autocancelreservation for example.
Steps To ReproduceInstall autocancelreservation
Create a layaway
Run the auto void layaway process
Check that the voiding process is failing due to the NPE
Proposed SolutionAttached patch
TagsNo tags attached.
Attached Filesdiff file icon z.diff [^] (1,094 bytes) 2019-09-19 10:38 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0043822RR19Q4.4 closedrqueralta VoidLayaway.java can throw NPE 

-  Notes
(0114888)
hgbot (developer)
2019-10-02 19:05

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9252cf8edbf5ee84c66917d7a45fab39db8e8bd1
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Sep 25 16:26:59 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9252cf8edbf5ee84c66917d7a45fab39db8e8bd1 [^]

Fixed issue 41852: VoidLayaway.java can throw NPE

- Avoided null pointer exception with autocancelreservation installed

---
M src/org/openbravo/retail/posterminal/VoidLayaway.java
---
(0114918)
jorge-garcia (reporter)
2019-10-04 11:27

 Code reviewed and tested

- Issue History
Date Modified Username Field Change
2019-09-19 10:38 airaceburu New Issue
2019-09-19 10:38 airaceburu Assigned To => Retail
2019-09-19 10:38 airaceburu File Added: z.diff
2019-09-19 10:38 airaceburu Resolution time => 1570053600
2019-09-19 10:38 airaceburu Triggers an Emergency Pack => No
2019-09-19 15:38 rqueralta Assigned To Retail => rqueralta
2019-09-19 15:38 rqueralta Status new => scheduled
2019-10-02 19:05 hgbot Checkin
2019-10-02 19:05 hgbot Note Added: 0114888
2019-10-02 19:05 hgbot Status scheduled => resolved
2019-10-02 19:05 hgbot Resolution open => fixed
2019-10-02 19:05 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9252cf8edbf5ee84c66917d7a45fab39db8e8bd1 [^]
2019-10-04 09:34 jorge-garcia Review Assigned To => jorge-garcia
2019-10-04 11:27 jorge-garcia Note Added: 0114918
2019-10-04 11:27 jorge-garcia Status resolved => closed
2019-10-04 11:27 jorge-garcia Fixed in Version => RR20Q1
2020-04-22 11:23 marvintm Regression level => Production - Confirmed Stable
2020-04-22 11:23 marvintm Regression date => 2019-05-29
2020-04-22 11:23 marvintm Regression introduced in release => RR19Q3
2020-04-22 11:23 marvintm Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1df20ca903a7#l1.8 [^]
2020-04-22 11:23 marvintm Status closed => new
2020-04-22 11:23 marvintm Resolution fixed => open
2020-04-22 11:23 marvintm Fixed in Version RR20Q1 =>
2020-04-22 11:23 marvintm Status new => acknowledged
2020-04-22 11:23 marvintm Status acknowledged => scheduled
2020-04-22 11:23 marvintm Status scheduled => resolved
2020-04-22 11:23 marvintm Fixed in Version => RR20Q3
2020-04-22 11:23 marvintm Resolution open => fixed
2020-04-22 11:24 marvintm Fixed in Version RR20Q3 => RR20Q1
2020-04-22 11:24 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker