Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041852Retail ModulesLayaway orderpublic2019-09-19 10:382020-04-22 11:24
Reporterairaceburu 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customerGold
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2019-05-29
Regression introduced in releaseRR19Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1df20ca903a7#l1.8 [^]
Triggers an Emergency PackNo
Summary0041852: VoidLayaway.java can throw NPE
DescriptionVoidLayaway.java is retrieving values from jsonorder without a sannity check. This value is sent as null from autocancelreservation for example.
Steps To ReproduceInstall autocancelreservation
Create a layaway
Run the auto void layaway process
Check that the voiding process is failing due to the NPE
Proposed SolutionAttached patch
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0043822RR19Q4.4 closed rqueralta VoidLayaway.java can throw NPE 
Attached Filesdiff z.diff (1,094) 2019-09-19 10:38
https://issues.openbravo.com/file_download.php?file_id=13308&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-09-19 10:38airaceburuNew Issue
2019-09-19 10:38airaceburuAssigned To => Retail
2019-09-19 10:38airaceburuFile Added: z.diff
2019-09-19 10:38airaceburuOBNetwork customer => Gold
2019-09-19 10:38airaceburuResolution time => 1570053600
2019-09-19 10:38airaceburuTriggers an Emergency Pack => No
2019-09-19 15:38rqueraltaAssigned ToRetail => rqueralta
2019-09-19 15:38rqueraltaStatusnew => scheduled
2019-10-02 19:05hgbotCheckin
2019-10-02 19:05hgbotNote Added: 0114888
2019-10-02 19:05hgbotStatusscheduled => resolved
2019-10-02 19:05hgbotResolutionopen => fixed
2019-10-02 19:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9252cf8edbf5ee84c66917d7a45fab39db8e8bd1 [^]
2019-10-04 09:34jorge-garciaReview Assigned To => jorge-garcia
2019-10-04 11:27jorge-garciaNote Added: 0114918
2019-10-04 11:27jorge-garciaStatusresolved => closed
2019-10-04 11:27jorge-garciaFixed in Version => RR20Q1
2020-04-22 11:23marvintmRegression level => Production - Confirmed Stable
2020-04-22 11:23marvintmRegression date => 2019-05-29
2020-04-22 11:23marvintmRegression introduced in release => RR19Q3
2020-04-22 11:23marvintmRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1df20ca903a7#l1.8 [^]
2020-04-22 11:23marvintmStatusclosed => new
2020-04-22 11:23marvintmResolutionfixed => open
2020-04-22 11:23marvintmFixed in VersionRR20Q1 =>
2020-04-22 11:23marvintmStatusnew => acknowledged
2020-04-22 11:23marvintmStatusacknowledged => scheduled
2020-04-22 11:23marvintmStatusscheduled => resolved
2020-04-22 11:23marvintmFixed in Version => RR20Q3
2020-04-22 11:23marvintmResolutionopen => fixed
2020-04-22 11:24marvintmFixed in VersionRR20Q3 => RR20Q1
2020-04-22 11:24marvintmStatusresolved => closed

Notes
(0114888)
hgbot   
2019-10-02 19:05   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9252cf8edbf5ee84c66917d7a45fab39db8e8bd1
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Sep 25 16:26:59 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9252cf8edbf5ee84c66917d7a45fab39db8e8bd1 [^]

Fixed issue 41852: VoidLayaway.java can throw NPE

- Avoided null pointer exception with autocancelreservation installed

---
M src/org/openbravo/retail/posterminal/VoidLayaway.java
---
(0114918)
jorge-garcia   
2019-10-04 11:27   
Code reviewed and tested