Anonymous | Login
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Discounts and Promotionsmajoralways2020-02-13 08:102020-02-21 12:35
ReporterpsarobeView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityurgentResolutionfixedFixed in VersionRR19Q4.2
StatusclosedFix in branchFixed in SCM revisiond0edc3692236
ProjectionnoneETAnoneTarget VersionRR19Q4.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Toguilleaer
Regression levelProduction - QA Approved
Regression date2019-08-02
Regression introduced in releaseRR19Q4
Regression introduced by commit [^]
Triggers an Emergency PackNo

0043283: Discounts with Characteristics. Having diferent characteristics work as "OR" instead of "AND"

DescriptionIf you have two characterstics:
- Season
- Brand

And you use these two in the characteristic tab as:
- Season: 2019
- Brand: Gucci

Instead of applying the discount to the products that are in season 2019 and Gucci is applying to either products in season 2019 or with brand Gucci
Steps To Reproduce1. Create two characteristics with values
2. In the discount and promotion window select price adjustment with 10%
3. Move to the Characteristics tab and add these two characteristics and with value in each.
4. Go to POS and see the result.

Expected result:
- Only for products that are season 2019 and Gucci

Current result:
- It is applying to either products that in season 2019 or Gucci
Proposed SolutionThis is the expected behaviour with the current definition. We need to improve the configuration options so that we can support both ways of working.

The proposal is the following:
- First we need to change the configuration options of the "Included characteristics". We need to replace the "Only the values defined" by "Any of the ones defined" (change only the displayed value, we should not change the internal value of the reflist to preserve the compatibility with previous data), and we need to add a new one called "All of the values defined".
- After that we need to change the discount-rules.js file (specifically the isApplicableToLine function), to take into account this new value, so that if it is set, all characteristic values specified in the discount need to be present in the product for the discount to be applicable to the line.
TagsNo tags attached.
Attached Filespatch file icon issue 43283 source discounts.patch [^] (1,644 bytes) 2020-02-21 06:56 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0043203 closedranjith_qualiantech_com Discounts with Characteristics. Having diferent characteristics work as "OR" instead of "AND" 

-  Notes
hgbot (developer)
2020-02-21 08:26

Repository: retail/backports/3.0RR19Q4.2/org.openbravo.retail.discounts
Changeset: d0edc3692236044886d89e90efd38a301dbc1bf7
Author: Ranjith S R <ranjith <at>>
Date: Fri Feb 21 11:23:04 2020 +0530
URL: [^]

Fixed issue 43283 : Updated Discount Calculation for Characteristics Definition

* If discount is defined with "Only those defined",
  then discount should be applied if any one of the characteristics present

M web/org.openbravo.retail.discounts/js/discountsengine/common/discount-rules.js

- Issue History
Date Modified Username Field Change
2020-02-20 15:31 ranjith_qualiantech_com Type defect => backport
2020-02-20 15:31 ranjith_qualiantech_com Target Version => RR19Q4.2
2020-02-21 06:56 ranjith_qualiantech_com File Added: issue 43283 source discounts.patch
2020-02-21 08:26 hgbot Checkin
2020-02-21 08:26 hgbot Note Added: 0117996
2020-02-21 08:26 hgbot Status scheduled => resolved
2020-02-21 08:26 hgbot Resolution open => fixed
2020-02-21 08:26 hgbot Fixed in SCM revision [^] => [^]
2020-02-21 12:35 guilleaer Review Assigned To => guilleaer
2020-02-21 12:35 guilleaer Status resolved => closed
2020-02-21 12:35 guilleaer Fixed in Version => RR19Q4.2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker