Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043283Retail ModulesDiscounts and Promotionspublic2020-02-13 08:102020-02-21 12:35
Reporterpsarobe 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionRR19Q4.2Fixed in VersionRR19Q4.2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2019-08-02
Regression introduced in releaseRR19Q4
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/711d273a9a3a/web/org.openbravo.retail.posterminal/js/model/order.js [^]
Triggers an Emergency PackNo
Summary0043283: Discounts with Characteristics. Having diferent characteristics work as "OR" instead of "AND"
DescriptionIf you have two characterstics:
- Season
- Brand

And you use these two in the characteristic tab as:
- Season: 2019
- Brand: Gucci

Instead of applying the discount to the products that are in season 2019 and Gucci is applying to either products in season 2019 or with brand Gucci
Steps To Reproduce1. Create two characteristics with values
2. In the discount and promotion window select price adjustment with 10%
3. Move to the Characteristics tab and add these two characteristics and with value in each.
4. Go to POS and see the result.

Expected result:
- Only for products that are season 2019 and Gucci

Current result:
- It is applying to either products that in season 2019 or Gucci
Proposed SolutionThis is the expected behaviour with the current definition. We need to improve the configuration options so that we can support both ways of working.

The proposal is the following:
- First we need to change the configuration options of the "Included characteristics". We need to replace the "Only the values defined" by "Any of the ones defined" (change only the displayed value, we should not change the internal value of the reflist to preserve the compatibility with previous data), and we need to add a new one called "All of the values defined".
- After that we need to change the discount-rules.js file (specifically the isApplicableToLine function), to take into account this new value, so that if it is set, all characteristic values specified in the discount need to be present in the product for the discount to be applicable to the line.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0043203 closed ranjith_qualiantech_com Discounts with Characteristics. Having diferent characteristics work as "OR" instead of "AND" 
Attached Filespatch issue 43283 source discounts.patch (1,644) 2020-02-21 06:56
https://issues.openbravo.com/file_download.php?file_id=14073&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-02-20 15:31ranjith_qualiantech_comTypedefect => backport
2020-02-20 15:31ranjith_qualiantech_comTarget Version => RR19Q4.2
2020-02-21 06:56ranjith_qualiantech_comFile Added: issue 43283 source discounts.patch
2020-02-21 08:26hgbotCheckin
2020-02-21 08:26hgbotNote Added: 0117996
2020-02-21 08:26hgbotStatusscheduled => resolved
2020-02-21 08:26hgbotResolutionopen => fixed
2020-02-21 08:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/38d39c4d560b2115a78f3dd41bd579e89c195124 [^] => http://code.openbravo.com/retail/backports/3.0RR19Q4.2/org.openbravo.retail.discounts/rev/d0edc3692236044886d89e90efd38a301dbc1bf7 [^]
2020-02-21 12:35guilleaerReview Assigned To => guilleaer
2020-02-21 12:35guilleaerStatusresolved => closed
2020-02-21 12:35guilleaerFixed in Version => RR19Q4.2

Notes
(0117996)
hgbot   
2020-02-21 08:26   
Repository: retail/backports/3.0RR19Q4.2/org.openbravo.retail.discounts
Changeset: d0edc3692236044886d89e90efd38a301dbc1bf7
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Feb 21 11:23:04 2020 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR19Q4.2/org.openbravo.retail.discounts/rev/d0edc3692236044886d89e90efd38a301dbc1bf7 [^]

Fixed issue 43283 : Updated Discount Calculation for Characteristics Definition

* If discount is defined with "Only those defined",
  then discount should be applied if any one of the characteristics present

---
M web/org.openbravo.retail.discounts/js/discountsengine/common/discount-rules.js
---