Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0042830
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformminorhave not tried2020-01-09 13:592020-01-14 10:15
ReportershuehnerView Statuspublic 
Assigned Toalostale 
PriorityurgentResolutionfixedFixed in Version3.0PR20Q1
StatusclosedFix in branchFixed in SCM revision3920e7daa2ad
ProjectionnoneETAnoneTarget Version3.0PR20Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042830: ant package.module is missing to exclude .git

DescriptionThe standard ant package.module task used to package modules by developers is missing to exclude .git folder.

It currently has excludes for both .hg & .svn but is missing to add same for .git

Consequence is it including all git repo history (if present) inside the obx file making them unnecessarily large.

On some occasions it can cause later secondary problem with module management as it tries to overwrite some read-only files inside .git in case of updating a module via mmc (having .git inside obx) when older module version also have .git files present.

Relevant code to which the new (.git) case should be added:
https://code.openbravo.com/erp/devel/pi/file/tip/src/org/openbravo/erpCommon/modules/ExtractModule.java#l232 [^]
Steps To ReproduceClone any module which is hosted as a git repository and run ant package.module to create obx file.

Check obx file (unzip -v) and notice it does contain .git.

TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks feature request 0042769 closedalostale ant package.module is missing to exclude .git 

-  Notes
(0116825)
hgbot (developer)
2020-01-14 09:54

Repository: erp/backports/3.0PR20Q1
Changeset: 3920e7daa2ad38aa3cb27c9575a20bb8c30be377
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jan 14 09:06:25 2020 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR20Q1/rev/3920e7daa2ad38aa3cb27c9575a20bb8c30be377 [^]

fixed ISSUE-42830: exclude .git directory when packaging modules

---
M src/org/openbravo/erpCommon/modules/ExtractModule.java
---
(0116829)
caristu (developer)
2020-01-14 10:15

Reviewed

- Issue History
Date Modified Username Field Change
2020-01-14 09:12 alostale Type feature request => backport
2020-01-14 09:12 alostale Target Version => 3.0PR20Q1
2020-01-14 09:54 hgbot Checkin
2020-01-14 09:54 hgbot Note Added: 0116825
2020-01-14 09:54 hgbot Status scheduled => resolved
2020-01-14 09:54 hgbot Resolution open => fixed
2020-01-14 09:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR20Q1/rev/3920e7daa2ad38aa3cb27c9575a20bb8c30be377 [^]
2020-01-14 10:15 caristu Note Added: 0116829
2020-01-14 10:15 caristu Status resolved => closed
2020-01-14 10:15 caristu Fixed in Version => 3.0PR20Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker