Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0042769
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminorhave not tried2020-01-09 13:592020-01-14 10:15
ReportershuehnerView Statuspublic 
Assigned Toalostale 
PriorityurgentResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision2bf4a5d49474
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042769: ant package.module is missing to exclude .git

DescriptionThe standard ant package.module task used to package modules by developers is missing to exclude .git folder.

It currently has excludes for both .hg & .svn but is missing to add same for .git

Consequence is it including all git repo history (if present) inside the obx file making them unnecessarily large.

On some occasions it can cause later secondary problem with module management as it tries to overwrite some read-only files inside .git in case of updating a module via mmc (having .git inside obx) when older module version also have .git files present.

Relevant code to which the new (.git) case should be added:
https://code.openbravo.com/erp/devel/pi/file/tip/src/org/openbravo/erpCommon/modules/ExtractModule.java#l232 [^]
Steps To ReproduceClone any module which is hosted as a git repository and run ant package.module to create obx file.

Check obx file (unzip -v) and notice it does contain .git.

TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00428303.0PR20Q1 closedalostale ant package.module is missing to exclude .git 
depends on backport 00428313.0PR19Q4.2 closedalostale ant package.module is missing to exclude .git 
depends on backport 00428323.0PR19Q3.4 closedalostale ant package.module is missing to exclude .git 
related to defect 0042775 closedshuehner ant package.core is tied to mercurial and cannot be used with ob source in git 
blocks feature request 0041898 acknowledgedTriage Platform Base support git 

-  Notes
(0116730)
shuehner (administrator)
2020-01-09 14:00

 We should think on potentially backporting this issue to last active releases.
a.) Fix should be trivial
b.) With OB moving to git that could avoid some accidents of people using older pi to package modules managed using git
(0116820)
alostale (viewer)
2020-01-14 09:14

 MR: https://gitlab.com/openbravo/product/openbravo/merge_requests/32 [^]
(0116824)
hgbot (developer)
2020-01-14 09:49

 Repository: erp/devel/pi
Changeset: 2bf4a5d49474cc41ce137fb6d8b41d5eb3a97b42
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jan 14 09:06:25 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2bf4a5d49474cc41ce137fb6d8b41d5eb3a97b42 [^]

fixed ISSUE-42769: exclude .git directory when packaging modules

---
M src/org/openbravo/erpCommon/modules/ExtractModule.java
---
(0116828)
caristu (viewer)
2020-01-14 10:15

 Reviewed

- Issue History
Date Modified Username Field Change
2020-01-09 13:59 shuehner New Issue
2020-01-09 13:59 shuehner Assigned To => platform
2020-01-09 13:59 shuehner OBNetwork customer => No
2020-01-09 13:59 shuehner Modules => Core
2020-01-09 13:59 shuehner Triggers an Emergency Pack => No
2020-01-09 14:00 shuehner Note Added: 0116730
2020-01-09 16:00 shuehner Relationship added related to 0042775
2020-01-14 09:10 alostale Assigned To platform => alostale
2020-01-14 09:10 alostale Review Assigned To => caristu
2020-01-14 09:11 alostale Relationship added blocks 0041898
2020-01-14 09:12 alostale Severity major => minor
2020-01-14 09:12 alostale Status new => scheduled
2020-01-14 09:14 alostale Note Added: 0116820
2020-01-14 09:49 hgbot Checkin
2020-01-14 09:49 hgbot Note Added: 0116824
2020-01-14 09:49 hgbot Status scheduled => resolved
2020-01-14 09:49 hgbot Resolution open => fixed
2020-01-14 09:49 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2bf4a5d49474cc41ce137fb6d8b41d5eb3a97b42 [^]
2020-01-14 10:15 caristu Note Added: 0116828
2020-01-14 10:15 caristu Status resolved => closed
2020-01-14 10:15 caristu Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker