Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042830Openbravo ERPA. Platformpublic2020-01-09 13:592020-01-14 10:15
Reportershuehner 
Assigned Toalostale 
PriorityurgentSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR20Q1Fixed in Version3.0PR20Q1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042830: ant package.module is missing to exclude .git
DescriptionThe standard ant package.module task used to package modules by developers is missing to exclude .git folder.

It currently has excludes for both .hg & .svn but is missing to add same for .git

Consequence is it including all git repo history (if present) inside the obx file making them unnecessarily large.

On some occasions it can cause later secondary problem with module management as it tries to overwrite some read-only files inside .git in case of updating a module via mmc (having .git inside obx) when older module version also have .git files present.

Relevant code to which the new (.git) case should be added:
https://code.openbravo.com/erp/devel/pi/file/tip/src/org/openbravo/erpCommon/modules/ExtractModule.java#l232 [^]
Steps To ReproduceClone any module which is hosted as a git repository and run ant package.module to create obx file.

Check obx file (unzip -v) and notice it does contain .git.

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0042769 closed alostale ant package.module is missing to exclude .git 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-14 09:12alostaleTypefeature request => backport
2020-01-14 09:12alostaleTarget Version => 3.0PR20Q1
2020-01-14 09:54hgbotCheckin
2020-01-14 09:54hgbotNote Added: 0116825
2020-01-14 09:54hgbotStatusscheduled => resolved
2020-01-14 09:54hgbotResolutionopen => fixed
2020-01-14 09:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR20Q1/rev/3920e7daa2ad38aa3cb27c9575a20bb8c30be377 [^]
2020-01-14 10:15caristuNote Added: 0116829
2020-01-14 10:15caristuStatusresolved => closed
2020-01-14 10:15caristuFixed in Version => 3.0PR20Q1

Notes
(0116825)
hgbot   
2020-01-14 09:54   
Repository: erp/backports/3.0PR20Q1
Changeset: 3920e7daa2ad38aa3cb27c9575a20bb8c30be377
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jan 14 09:06:25 2020 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR20Q1/rev/3920e7daa2ad38aa3cb27c9575a20bb8c30be377 [^]

fixed ISSUE-42830: exclude .git directory when packaging modules

---
M src/org/openbravo/erpCommon/modules/ExtractModule.java
---
(0116829)
caristu   
2020-01-14 10:15   
Reviewed