Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0042672
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajoralways2020-01-02 08:542020-01-21 09:43
ReporterguillermogilView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR20Q1
StatusclosedFix in branchFixed in SCM revisione029e033236f
ProjectionnoneETAnoneTarget VersionRR20Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042672: Save on PostAddPaymentHook breaks custom functionality

DescriptionSave on PostAddPaymentHook breaks custom functionality on 20Q1 due to a new save done after the hook
Steps To ReproduceOn postAddPaymentHook execute the following:
order.trigger('paymentDone', OB.UTIL.isOpenDrawer(payment));

WebPOS breaks.
Proposed SolutionSee diff attached.

With the proposed diff the hook has control on whether the save should happen or not, and therefore can prevent the problem from happening.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0042671 closedranjith_qualiantech_com Save on PostAddPaymentHook breaks custom functionality 

-  Notes
(0116623)
hgbot (developer)
2020-01-03 10:14

Repository: retail/backports/3.0RR20Q1/org.openbravo.retail.posterminal
Changeset: e029e033236ff15ea329b37e095248b1ef0675dd
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jan 03 14:30:20 2020 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR20Q1/org.openbravo.retail.posterminal/rev/e029e033236ff15ea329b37e095248b1ef0675dd [^]

Fixed issue 42672 : Updated PostAddPayment hook arguments

* saveChanges values should be added to PostAddPayment hook

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---

- Issue History
Date Modified Username Field Change
2020-01-02 08:58 marvintm Type defect => backport
2020-01-02 08:58 marvintm Target Version => RR20Q1
2020-01-03 10:14 hgbot Checkin
2020-01-03 10:14 hgbot Note Added: 0116623
2020-01-03 10:14 hgbot Status scheduled => resolved
2020-01-03 10:14 hgbot Resolution open => fixed
2020-01-03 10:14 hgbot Fixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR20Q1/org.openbravo.retail.posterminal/rev/e029e033236ff15ea329b37e095248b1ef0675dd [^]
2020-01-21 09:43 guilleaer Review Assigned To => guilleaer
2020-01-21 09:43 guilleaer Status resolved => closed
2020-01-21 09:43 guilleaer Fixed in Version => RR20Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker