Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042672Retail ModulesWeb POSpublic2020-01-02 08:542020-01-21 09:43
Reporterguillermogil 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR20Q1Fixed in VersionRR20Q1 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042672: Save on PostAddPaymentHook breaks custom functionality
DescriptionSave on PostAddPaymentHook breaks custom functionality on 20Q1 due to a new save done after the hook
Steps To ReproduceOn postAddPaymentHook execute the following:
order.trigger('paymentDone', OB.UTIL.isOpenDrawer(payment));

WebPOS breaks.
Proposed SolutionSee diff attached.

With the proposed diff the hook has control on whether the save should happen or not, and therefore can prevent the problem from happening.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0042671 closed ranjith_qualiantech_com Save on PostAddPaymentHook breaks custom functionality 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-02 08:58marvintmTypedefect => backport
2020-01-02 08:58marvintmTarget Version => RR20Q1
2020-01-03 10:14hgbotCheckin
2020-01-03 10:14hgbotNote Added: 0116623
2020-01-03 10:14hgbotStatusscheduled => resolved
2020-01-03 10:14hgbotResolutionopen => fixed
2020-01-03 10:14hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR20Q1/org.openbravo.retail.posterminal/rev/e029e033236ff15ea329b37e095248b1ef0675dd [^]
2020-01-21 09:43guilleaerReview Assigned To => guilleaer
2020-01-21 09:43guilleaerStatusresolved => closed
2020-01-21 09:43guilleaerFixed in Version => RR20Q1

Notes
(0116623)
hgbot   
2020-01-03 10:14   
Repository: retail/backports/3.0RR20Q1/org.openbravo.retail.posterminal
Changeset: e029e033236ff15ea329b37e095248b1ef0675dd
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jan 03 14:30:20 2020 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR20Q1/org.openbravo.retail.posterminal/rev/e029e033236ff15ea329b37e095248b1ef0675dd [^]

Fixed issue 42672 : Updated PostAddPayment hook arguments

* saveChanges values should be added to PostAddPayment hook

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---